This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix hardware keyboard enter so it triggers an action. #15568
Merged
+82
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
fix_keyboard_enter
branch
2 times, most recently
from
2ccaf38 to
6e8aaf3
Compare
gspencergoog
force-pushed
the
fix_keyboard_enter
branch
2 times, most recently
from
15a923a to
4e8f63e
Compare
gspencergoog
commented
Jan 14, 2020
shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java
Outdated
Show resolved
Hide resolved
gspencergoog
force-pushed
the
fix_keyboard_enter
branch
2 times, most recently
from
d256a63 to
2a2c79b
Compare
mklim
approved these changes
Jan 14, 2020
shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java
Show resolved
Hide resolved
shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java
Outdated
Show resolved
Hide resolved
gspencergoog
force-pushed
the
fix_keyboard_enter
branch
from
04ec9ce to
47914f9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2020
flutter/engine@3488051...be20fb6 git log 3488051..be20fb6 --first-parent --oneline 2020-01-15 [email protected] [web] Exec command copy (flutter/engine#15675) 2020-01-15 [email protected] Disable fml_unittests till flakes are addressed. (flutter/engine#15676) 2020-01-15 [email protected] Roll src/third_party/dart fe666ce592cb..862d5012ae9c (48 commits) (flutter/engine#15672) 2020-01-15 [email protected] Fix hardware keyboard enter so it triggers an action. (flutter/engine#15568) 2020-01-15 [email protected] Use iOS 13 dark content status bar style (flutter/engine#13119) 2020-01-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from oxHfW... to UlOSN... (flutter/engine#15670) 2020-01-15 [email protected] Roll src/third_party/skia e45c5cd03eeb..7655168e6865 (29 commits) (flutter/engine#15671) 2020-01-15 [email protected] Fix embedder mutation order (flutter/engine#15566) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This was referenced Feb 10, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This changes the InputConnectionAdaptor so that it will execute an IME action when ENTER is pressed. Prior to this, pressing ENTER on a hardware keyboard did nothing.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
This changes the InputConnectionAdaptor so that it will execute an IME action when ENTER is pressed. Prior to this, pressing ENTER on a hardware keyboard did nothing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the InputConnectionAdaptor so that it will execute an IME action when ENTER is pressed. Prior to this, pressing ENTER on a hardware keyboard did nothing.
Related Issues
Tests