This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix blendmode for images #13809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Nov 13, 2019
| final HtmlImage htmlImage = image; | ||
| final html.Element imgElement = htmlImage.cloneImageElement(); | ||
| final html.ImageElement imgElement = htmlImage.cloneImageElement(); | ||
| String blendMode = ctx.globalCompositeOperation; |
Contributor
There was a problem hiding this comment.
nit: final? Or not create a variable? It seems to be used only once.
harryterkelsen
approved these changes
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2019
[email protected]:flutter/engine.git/compare/b358dc58fbce...b6a0fb7 git log b358dc5..b6a0fb7 --no-merges --oneline 2019-11-13 [email protected] [web] Fix blendmode for images (flutter/engine#13809) 2019-11-13 [email protected] Roll buildroot to 0fec442. (flutter/engine#13837) 2019-11-13 [email protected] reland add lifecycle enum (flutter/engine#13767) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/goldens#65