This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure that the CAMetalLayer FBO attachments can be read from. #13643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the CAMetalLayer backing store is a framebuffer attachment that is only optimized for display. However, effects such as backdrop filters require renderbuffer readback. Making this calls will result in exceptions. Disable the write only optimization on such backing store. Fixes flutter/flutter#43555
dnfield
approved these changes
Nov 5, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM.
Can we optimize this by updating the layer tree so that it sets this bit if a backdrop filter is added?
Member
Author
Yes. I can do this in a later patch. Currently, the performance characteristics should match OpenGL. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2019
[email protected]:flutter/engine.git/compare/e73c9c8f6bd5...7b968ff git log e73c9c8..7b968ff --no-merges --oneline 2019-11-05 [email protected] Ensure that the CAMetalLayer FBO attachments can be read from. (flutter/engine#13643) 2019-11-04 [email protected] Revert "Added new lifecycle enum (#11913)" (flutter/engine#13632) 2019-11-04 [email protected] Added new lifecycle enum (flutter/engine#11913) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/e73c9c8f6bd5...7b968ff git log e73c9c8..7b968ff --no-merges --oneline 2019-11-05 [email protected] Ensure that the CAMetalLayer FBO attachments can be read from. (flutter/engine#13643) 2019-11-04 [email protected] Revert "Added new lifecycle enum (flutter#11913)" (flutter/engine#13632) 2019-11-04 [email protected] Added new lifecycle enum (flutter/engine#11913) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the CAMetalLayer backing store is a framebuffer attachment that is
only optimized for display. However, effects such as backdrop filters require
renderbuffer readback. Making these calls will result in exceptions. Disable the
write only optimization on such backing stores.
Fixes flutter/flutter#43555
Fixes flutter/flutter#43789