This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Converted ActivityAware and ServiceAware Lifecycles to opaque objects (#43670) #13402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
reviewed
Oct 29, 2019
| * Returns the {@link Lifecycle} associated with the attached {@code Activity}. | ||
| * Returns the {@code Lifecycle} associated with the attached {@code Activity}. | ||
| * <p> | ||
| * Use the flutter_plugin_android_lifecycle plugin to turn the returned {@code Object} |
Member
There was a problem hiding this comment.
Add a link?
Also describe that the purpose is to get a Lifecyle version compatible with the engine. Since the target audience is the plugin developer here, we can probably mention that this should match the Lifecycle version they declare in pub.
Contributor
Author
There was a problem hiding this comment.
Sure, done.
13 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 30, 2019
[email protected]:flutter/engine.git/compare/419f5d594afc...46c757b git log 419f5d5..46c757b --no-merges --oneline 2019-10-29 [email protected] [dart_runner] Common libs need to exist for aot runner (flutter/engine#13419) 2019-10-29 [email protected] Fix the dry run mode of the GN format checker script (flutter/engine#13406) 2019-10-29 [email protected] Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401) 2019-10-29 [email protected] Use DartExecutor.getBinaryMessenger in FlutterNativeView instead of deprecated send methods (flutter/engine#13403) 2019-10-29 [email protected] Roll src/third_party/dart e1fce75301..0b96f9f9ae (28 commits) 2019-10-29 [email protected] Converted ActivityAware and ServiceAware Lifecycles to opaque objects (#43670) (flutter/engine#13402) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/419f5d594afc...46c757b git log 419f5d5..46c757b --no-merges --oneline 2019-10-29 [email protected] [dart_runner] Common libs need to exist for aot runner (flutter/engine#13419) 2019-10-29 [email protected] Fix the dry run mode of the GN format checker script (flutter/engine#13406) 2019-10-29 [email protected] Reformat BUILD.gn files to comply with the format checker presubmit script (flutter/engine#13401) 2019-10-29 [email protected] Use DartExecutor.getBinaryMessenger in FlutterNativeView instead of deprecated send methods (flutter/engine#13403) 2019-10-29 [email protected] Roll src/third_party/dart e1fce75301..0b96f9f9ae (28 commits) 2019-10-29 [email protected] Converted ActivityAware and ServiceAware Lifecycles to opaque objects (flutter#43670) (flutter/engine#13402) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted ActivityAware and ServiceAware Lifecycles to opaque objects (#43670)