Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Update the url when route is replaced #13003

Merged
mdebbar merged 1 commit into from
Oct 8, 2019
Merged

[web] Update the url when route is replaced #13003

mdebbar merged 1 commit into from
Oct 8, 2019

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 8, 2019

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Oct 8, 2019
@mdebbar mdebbar requested a review from nturgut October 8, 2019 21:13
@mdebbar mdebbar self-assigned this Oct 8, 2019
nturgut
nturgut approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@nturgut nturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdebbar mdebbar merged commit 6113ef9 into flutter:master Oct 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2019
@engine-flutter-autoroll
6113ef9 [web] Update the url when route is replaced (flutter/engine#1…
99baa00 
…3003)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 9, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 9, 2019
@engine-flutter-autoroll
Roll engine c635d70..21b8224 (10 commits) (#42285)
8159a99 
[email protected]:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 [email protected] Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
2019-10-08 [email protected] Fix for a11y crash on iOS (flutter/engine#12990)
2019-10-08 [email protected] Link Semantics Typo (flutter/engine#13009)
2019-10-08 [email protected] [web] Add support for path transform (flutter/engine#12794)
2019-10-08 [email protected] Auto-formatter fixes for BUILD.gn files (flutter/engine#13005)
2019-10-08 [email protected] Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
2019-10-08 [email protected] [web] Update the url when route is replaced (flutter/engine#13003)
2019-10-08 [email protected] Missing link flag (flutter/engine#13001)
2019-10-08 [email protected] Started setting our debug background task id to invalid after completion. (flutter/engine#12999)
2019-10-08 [email protected] Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine c635d70..21b8224 (10 commits) (flutter#42285)
a5e1b91 
[email protected]:flutter/engine.git/compare/c635d70c7266...21b8224

git log c635d70..21b8224 --no-merges --oneline
2019-10-08 [email protected] Send AccessibilityEvent.TYPE_VIEW_FOCUSED when input focus is set. (flutter/engine#12746)
2019-10-08 [email protected] Fix for a11y crash on iOS (flutter/engine#12990)
2019-10-08 [email protected] Link Semantics Typo (flutter/engine#13009)
2019-10-08 [email protected] [web] Add support for path transform (flutter/engine#12794)
2019-10-08 [email protected] Auto-formatter fixes for BUILD.gn files (flutter/engine#13005)
2019-10-08 [email protected] Unblock SIGPROF on flutter_tester start (flutter/engine#12813)
2019-10-08 [email protected] [web] Update the url when route is replaced (flutter/engine#13003)
2019-10-08 [email protected] Missing link flag (flutter/engine#13001)
2019-10-08 [email protected] Started setting our debug background task id to invalid after completion. (flutter/engine#12999)
2019-10-08 [email protected] Add `onUnregistered` callback in 'Texture' and 'FlutterTexture' (flutter/engine#12695)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@mdebbar mdebbar deleted the fix_replace_route branch April 15, 2021 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nturgut nturgut nturgut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdebbar mdebbar

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Navigator.pushReplacementNamed does not update address bar

3 participants

@mdebbar @nturgut @googlebot