This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support accessibility labels on iOS switches. #12404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondiamond
added a commit
to brandondiamond/flutter
that referenced
this pull request
Sep 23, 2019
brandondiamond
requested review from
jonahwilliams
and removed request for
jonahwilliams
9 tasks
brandondiamond
changed the title
Contributor
|
@brandondiamond I think you might be synced to a bad PR, can you pull an updated master into your PR? |
Contributor
|
Also, please check the errors due to code formatting |
Contributor
Author
|
Fixed formatting and merged with master (hopefully my git-fu didn't mess everything up)! |
Contributor
Author
|
Missed a change in web_ui, should be fixed and ready for review :) Thanks again, Jonah. |
Member
|
This commit is causing iOS LUCI failures. |
Member
|
|
chinmaygarde
added a commit
that referenced
this pull request
Sep 26, 2019
This reverts commit 147d0c3.
chinmaygarde
added a commit
that referenced
this pull request
Sep 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2019
[email protected]:flutter/engine.git/compare/b126ba758533...5b5fd75 git log b126ba7..5b5fd75 --no-merges --oneline 2019-09-26 [email protected] Revert "Support accessibility labels on iOS switches. (#12404)" (flutter/engine#12466) 2019-09-26 [email protected] Support accessibility labels on iOS switches. (flutter/engine#12404) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
[email protected]:flutter/engine.git/compare/b126ba758533...5b5fd75 git log b126ba7..5b5fd75 --no-merges --oneline 2019-09-26 [email protected] Revert "Support accessibility labels on iOS switches. (flutter#12404)" (flutter/engine#12466) 2019-09-26 [email protected] Support accessibility labels on iOS switches. (flutter/engine#12404) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
18 tasks
cbracken
reviewed
Oct 21, 2019
| [center addObserver:self | ||
| selector:@selector(onAccessibilityStatusChanged:) | ||
| name:UIAccessibilityOnOffSwitchLabelsDidChangeNotification | ||
| object:nil]; |
Member
There was a problem hiding this comment.
When this is re-landed, only one of these two duplicate notifications should be applied. See #12464.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the engine change needed to support flutter/flutter#39993.
Queries / tracks the accessibility in iOS and plumbs it through to the framework via AccessibilityFeatures.
Issue: flutter/flutter#4830.