This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[flutter_runner] Refactor our build rules to make them more inline with topaz #12034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Sep 6, 2019
Member
|
The check that runs |
…th topaz. Also add flutter tool support for topaz in-tree builds that already have a dependency on the framework repository. After this the only major changes left are profiler symbols and Framework mode. This should make making topaz use our buldrules significantly easier.
iskakaushik
force-pushed
the
flutter_runner_port
branch
from
ac2b4d7 to
c0f06ec
Compare
Contributor
Author
|
@jason-simmons i missed one of the imports. Fixed it! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2019
…nline with topaz. (flutter/engine#12034)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2019
…nline with topaz. (flutter/engine#12034) (#40018) [email protected]:flutter/engine.git/compare/50bdbd769eee...c9ea4db git log 50bdbd7..c9ea4db --no-merges --oneline 2019-09-06 [email protected] [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter/engine#12034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
gspencergoog
added a commit
to gspencergoog/flutter
that referenced
this pull request
Sep 9, 2019
…hem more inline with topaz. (flutter/engine#12034) (flutter#40018)" This reverts commit 5a3a46a.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
…nline with topaz. (flutter/engine#12034)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
…nline with topaz. (flutter/engine#12034)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
…nline with topaz. (flutter/engine#12034)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
…nline with topaz. (flutter/engine#12034)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2019
…nline with topaz. (flutter/engine#12034)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add flutter tool support for topaz in-tree builds that already have
a dependency on the framework repository.
After this the only major changes left are profiler symbols and
Framework mode.
This should make making topaz use our buldrules significantly easier.