This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Document dependencies and remove support-v13 #11912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
reviewed
Sep 6, 2019
| "out_file_name": "android_arch_lifecycle_viewmodel.jar", | ||
| "maven_dependency": "android.arch.lifecycle:viewmodel:1.1.1" | ||
| "maven_dependency": "android.arch.lifecycle:viewmodel:1.1.1", | ||
| "provides": [] |
Member
There was a problem hiding this comment.
does this mean this can be deleted too?
Author
There was a problem hiding this comment.
these are still needed to compile the embedding. This is a transitive dependency of support-fragment.
Member
There was a problem hiding this comment.
I see, you're saying this ends up in the user's APK either way ultimately?
Author
There was a problem hiding this comment.
correct. Gradle will bring this dependency anyways.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2019
[email protected]:flutter/engine.git/compare/7ea9884ab00e...50bdbd7 git log 7ea9884..50bdbd7 --no-merges --oneline 2019-09-06 [email protected] Document dependencies and remove support-v13 (flutter/engine#11912) 2019-09-06 [email protected] Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 2019-09-06 [email protected] Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter/engine#12031) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android_support_v13.jarsince it's not needed.