This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Improve input method and Unicode character display(#30661) #11899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Whoa, we used Could you please add some tests that test adding non-ASCII Unicode strings? |
Contributor
FWIW, the goal at the time of writing was "just get basic ASCII input working". We knew it would need to be rewritten. |
stuartmorgan-g
suggested changes
Sep 5, 2019
stuartmorgan-g
suggested changes
Sep 6, 2019
shoryukenn
force-pushed
the
issues_30661
branch
from
27aa403 to
ad7984b
Compare
stuartmorgan-g
suggested changes
Sep 7, 2019
stuartmorgan-g
approved these changes
Sep 8, 2019
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Looks good; this should be a significant improvement. Thanks!
I'll summarize the work I'm aware is remaining in the bug; please add anything else that you know of.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We optimized the character handling so that it can accept and display Unicode characters well.
We use the standard library: codecvt, which is already used in flutter/fml. codecvt handles complex and error-prone character conversion logic that was previously handled separately on each platform. (Example: utf8/16/32, wchar_t(16/32)...)
ISSUE: flutter/flutter#30661