last flutter web sync: cc38319841 #11732
Conversation
| max, | ||
| } | ||
|
|
||
| class LineMetrics { |
There was a problem hiding this comment.
Seems like you'll want this?
There was a problem hiding this comment.
Hold on! Gotta revert a little more...
| } | ||
|
|
||
| @override | ||
| List<ui.LineMetrics> computeLineMetrics() { |
There was a problem hiding this comment.
Return empty List here?
There was a problem hiding this comment.
Done. Should be good now. Once and for all!
| } | ||
|
|
||
| @override | ||
| List<ui.LineMetrics> computeLineMetrics() { |
There was a problem hiding this comment.
cc @GaryQian does anything in flutter call this yet? Will returning null be safe here?
There was a problem hiding this comment.
Nothing calls this yet. API just landed today/yesterday. Should be safe to return null.
There was a problem hiding this comment.
If you look at the overall diff for this PR you'll notice that there's no change here. IOW, returning null is exactly what we're already doing. However, I filed an issue for us to implement this properly: flutter/flutter#39537
There was a problem hiding this comment.
I updated the TODO with the issue link
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM.
I'll send a PR after this to update the API check script to enforce no docs in web_ui (not in engine).
* 37c5510 Roll src/third_party/skia ca8b07cf8a59..3783375c4d41 (2 commits) (flutter/engine#11712) * 74a3c73 Roll src/third_party/dart 35382f9b14..05c28c6115 (flutter/engine#11702) * 7024722 Android 10+ View.setSystemGestureExclusionRects (flutter/engine#11441) * 101e03c Return a JSON value for the Skia channel (flutter/engine#11717) * dce8a34 Revert "Notify framework to clear input connection when app is backgrounded (#35054) (#9498)" (flutter/engine#11720) * 1b1f781 Quote the font family name whenever setting the font-family property. (flutter/engine#11722) * 260f88d Roll src/third_party/skia 3783375c4d41..165ca3f85b7a (8 commits) (flutter/engine#11725) * e620012 Roll src/third_party/dart 05c28c6115..1573f4e877 (14 commits) * 81e010f last flutter web sync: cc38319841 (flutter/engine#11732) * 1235439 Roll src/third_party/dart 1573f4e877..fd48ea3432 (16 commits) * cf5d2a6 Add wasm to sky_engine (flutter/engine#11736) * 118b5f3 Roll src/third_party/dart fd48ea3432..a873bc5db3 (7 commits) * a7d59aa Roll src/third_party/skia 165ca3f85b7a..ba0a2c7ad992 (1 commits) (flutter/engine#11745) * 8401ce9 Roll src/third_party/dart a873bc5db3..35df96a2e2 (1 commits) * ff3dffa Roll src/third_party/skia ba0a2c7ad992..7409b73fa546 (3 commits) (flutter/engine#11756) * 70626c0 Roll src/third_party/skia 7409b73fa546..575699569e91 (1 commits) (flutter/engine#11766) * 292d844 Roll src/third_party/dart 35df96a2e2..d4342b9021 (4 commits)
4 participants
This syncs Flutter Web engine to https://github.com/flutter/flutter_web/commit/cc38319841009fcbdf632d9b03aab18d28939438.
This is the last sync. Future changes will be done by submitting and reviewing pull requests in this repository.
/cc @ferhatb @hterkelsen @nturgut @mdebbar @jonahwilliams