This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Return a JSON value for the Skia channel #11717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2019
This was referenced Aug 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2019
[email protected]:flutter/engine.git/compare/9a17d8e45197...101e03c git log 9a17d8e..101e03c --no-merges --oneline 2019-08-29 [email protected] Return a JSON value for the Skia channel (flutter/engine#11717) 2019-08-29 [email protected] Android 10+ View.setSystemGestureExclusionRects (flutter/engine#11441) 2019-08-29 [email protected] Roll src/third_party/dart 35382f9b14..05c28c6115 (flutter/engine#11702) 2019-08-29 [email protected] Roll src/third_party/skia ca8b07cf8a59..3783375c4d41 (2 commits) (flutter/engine#11712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2019
GaryQian
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2019
* 37c5510 Roll src/third_party/skia ca8b07cf8a59..3783375c4d41 (2 commits) (flutter/engine#11712) * 74a3c73 Roll src/third_party/dart 35382f9b14..05c28c6115 (flutter/engine#11702) * 7024722 Android 10+ View.setSystemGestureExclusionRects (flutter/engine#11441) * 101e03c Return a JSON value for the Skia channel (flutter/engine#11717) * dce8a34 Revert "Notify framework to clear input connection when app is backgrounded (#35054) (#9498)" (flutter/engine#11720) * 1b1f781 Quote the font family name whenever setting the font-family property. (flutter/engine#11722) * 260f88d Roll src/third_party/skia 3783375c4d41..165ca3f85b7a (8 commits) (flutter/engine#11725) * e620012 Roll src/third_party/dart 05c28c6115..1573f4e877 (14 commits) * 81e010f last flutter web sync: cc38319841 (flutter/engine#11732) * 1235439 Roll src/third_party/dart 1573f4e877..fd48ea3432 (16 commits) * cf5d2a6 Add wasm to sky_engine (flutter/engine#11736) * 118b5f3 Roll src/third_party/dart fd48ea3432..a873bc5db3 (7 commits) * a7d59aa Roll src/third_party/skia 165ca3f85b7a..ba0a2c7ad992 (1 commits) (flutter/engine#11745) * 8401ce9 Roll src/third_party/dart a873bc5db3..35df96a2e2 (1 commits) * ff3dffa Roll src/third_party/skia ba0a2c7ad992..7409b73fa546 (3 commits) (flutter/engine#11756) * 70626c0 Roll src/third_party/skia 7409b73fa546..575699569e91 (1 commits) (flutter/engine#11766) * 292d844 Roll src/third_party/dart 35df96a2e2..d4342b9021 (4 commits)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#39337 - for real this time.
The framework side expects responses to this to be valid JSON encoded as a list. See https://github.com/flutter/flutter/blob/14cec30c18b5ada61e5cdb6a8fd3428ccc023e85/packages/flutter/lib/src/services/message_codecs.dart#L140
/cc @abhishekamit