Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 26, 2019

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@dnfield
Copy link
Contributor Author

dnfield commented Aug 26, 2019

I'm landing this before the presubmits finish because it only can potentially impact the post submits (or the steps the presubmits ahave completed for the buildroot roll). And I want to test this out to see if it lets me re-enable bitcode on CI, which is a bit of a slow process right now.

@dnfield dnfield merged commit eb92b09 into flutter:master Aug 26, 2019
@dnfield dnfield deleted the bitcode_marker branch August 26, 2019 19:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 26, 2019
[email protected]:flutter/engine.git/compare/ba1a303ae2d7...9f1eab2

git log ba1a303..9f1eab2 --no-merges --oneline
2019-08-26 [email protected] Expose LineMetrics in dart:ui (flutter/engine#10670)
2019-08-26 [email protected] Roll buildroot and update gn script for bitcode_marker (flutter/engine#11449)
2019-08-26 [email protected] Roll src/third_party/skia d617d5d29ca5..464eb78e444b (10 commits) (flutter/engine#11444)
2019-08-26 [email protected] Roll fuchsia/clang/mac-amd64 from RDjN2... to CGYQg... (flutter/engine#11442)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS debug optimized engine should use -fembed-bitcode-marker

3 participants