This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Trivial: remove empty line in the pom file #11382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Aug 22, 2019
| # The template for the POM file. | ||
| POM_FILE_CONTENT = ''' | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| POM_FILE_CONTENT = '''<?xml version="1.0" encoding="UTF-8"?> |
Contributor
There was a problem hiding this comment.
I'm fine landing this as is to unbreak things, but is there a nice way we could test this?
Author
There was a problem hiding this comment.
One option is to unit test this code, but there isn't a good way to do that currently. The other option is to consume the artifacts in Gradle, but I don't think Gradle is installed on LUCI.
dnfield
approved these changes
Aug 22, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM. Would be really nice to have a test in this repo for this.
Author
|
Discussed offline. The engine roll into Flutter should catch any error in the POM file. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2019
[email protected]:flutter/engine.git/compare/78ac65320bde...975a8aa git log 78ac653..975a8aa --no-merges --oneline 2019-08-23 [email protected] Roll src/third_party/dart 022585cfe2..06d3769ac6 (12 commits) 2019-08-23 [email protected] Roll src/third_party/skia 941d0a365045..f17d1c952987 (1 commits) (flutter/engine#11393) 2019-08-23 [email protected] Wire up software rendering in the test compositor. (flutter/engine#11392) 2019-08-23 [email protected] Roll src/third_party/dart 88c0c11612..022585cfe2 (14 commits) 2019-08-23 [email protected] preventDefault on touchend to show iOS keyboard (flutter/engine#11390) 2019-08-23 [email protected] Roll src/third_party/skia 2a5954140b49..941d0a365045 (6 commits) (flutter/engine#11389) 2019-08-22 [email protected] Allow overriding the GLFW pixel ratio (flutter/engine#11388) 2019-08-22 [email protected] Allow non-resizable windows in GLFW embedding (flutter/engine#11386) 2019-08-22 [email protected] sync web engine; run web engine tests (flutter/engine#11031) 2019-08-22 [email protected] Reland "Track detailed LibTxt metrics with LineMetrics(#10127)" (flutter/engine#11064) 2019-08-22 [email protected] Remove empty line in the pom file (flutter/engine#11382) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.