Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

This makes it so that the texture obtained by the next frame has the same dimensions as the frame being renderered.

Fixes flutter/flutter#38754

This makes it so that the texture obtained by the next frame has the same dimensions as the frame being renderered.

Fixes flutter/flutter#38754
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit 84bd736 into flutter:master Aug 19, 2019
@chinmaygarde chinmaygarde deleted the fix_metal_rotation branch August 19, 2019 20:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 20, 2019
[email protected]:flutter/engine.git/compare/21ae92651a38...3e10d92

git log 21ae926..3e10d92 --no-merges --oneline
2019-08-19 [email protected] Roll src/third_party/dart 0e201edeeb..9f13d07670 (27 commits)
2019-08-19 [email protected] Notify framework to clear input connection when app is backgrounded (#35054) (flutter/engine#9498)
2019-08-19 [email protected] Re-enable firebase test and don't use google login (flutter/engine#11228)
2019-08-19 [email protected] Update tflite_native and language_model revisions to match the Dart SDK (flutter/engine#11230)
2019-08-19 [email protected] Roll src/third_party/skia f8221786d088..8566dda51b42 (4 commits) (flutter/engine#11220)
2019-08-19 [email protected] Update metal layer drawable size on relayout. (flutter/engine#11224)
2019-08-19 [email protected] Make firebase testlab always pass (flutter/engine#11226)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metal backend doesn't respond to screen rotation properly

3 participants