This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Initialize the engine in the running state to match the animator's default state #11011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault state The engine's activity_running flag tracks whether the app is in the paused or running lifecycle state. The engine had been defaulting activity_running to false (meaning paused). But the animator had been defaulting its paused flag to false, which allowed frames to render at startup. If the engine loses and regains its surface, then frames would stop rendering because activity_running is false (even though frames had been rendering when the engine initially acquired its surface). This change puts the engine and the animator into a consistent state at startup. Frames will continue to render until the embedder sends a lifecycle message that will pause both the engine and the animator. See flutter/flutter#32624
chinmaygarde
approved these changes
Aug 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2019
…tor's default state (flutter/engine#11011)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 15, 2019
[email protected]:flutter/engine.git/compare/c5e30553cd1a...5e155c6 git log c5e3055..5e155c6 --no-merges --oneline 2019-08-14 [email protected] some drive-by docs while I was reading the embedding classes (flutter/engine#9341) 2019-08-14 [email protected] Initialize the engine in the running state to match the animator's default state (flutter/engine#11011) 2019-08-14 [email protected] Trace RasterCacheResult::Draw (flutter/engine#11004) 2019-08-14 [email protected] Rename macOS FLE* classes to Flutter* (flutter/engine#11010) 2019-08-14 [email protected] [Windows] Alternative Windows shell platform implementation (flutter/engine#9835) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine's activity_running flag tracks whether the app is in the paused or
running lifecycle state. The engine had been defaulting activity_running to
false (meaning paused). But the animator had been defaulting its paused flag
to false, which allowed frames to render at startup. If the engine loses and
regains its surface, then frames would stop rendering because activity_running
is false (even though frames had been rendering when the engine initially
acquired its surface).
This change puts the engine and the animator into a consistent state at
startup. Frames will continue to render until the embedder sends a lifecycle
message that will pause both the engine and the animator.
See flutter/flutter#32624