This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename macOS FLE* classes to Flutter* #11010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
reviewed
Aug 14, 2019
| * Controls embedder plugins and communication with the underlying Flutter engine, managing a view | ||
| * intended to handle key inputs and drawing protocols (see |view|). | ||
| * | ||
| * Can be launched headless (no managed view), at which point a Dart executable will be run on the |
Contributor
There was a problem hiding this comment.
Can this no longer be headless? I was curious why this got removed.
Contributor
Author
There was a problem hiding this comment.
This comment was cruft from an API fix that already happened. The original FDE APIs had grafted headless mode onto the view controller, which made no sense. That has since been fixed to align the overall API with iOS, where there's a FlutterEngine that you use directly for headless execution. I forgot to update this comment when I made that change, and noticed it while doing this rename.
stuartmorgan-g
added
affects: desktop
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 15, 2019
[email protected]:flutter/engine.git/compare/c5e30553cd1a...5e155c6 git log c5e3055..5e155c6 --no-merges --oneline 2019-08-14 [email protected] some drive-by docs while I was reading the embedding classes (flutter/engine#9341) 2019-08-14 [email protected] Initialize the engine in the running state to match the animator's default state (flutter/engine#11011) 2019-08-14 [email protected] Trace RasterCacheResult::Draw (flutter/engine#11004) 2019-08-14 [email protected] Rename macOS FLE* classes to Flutter* (flutter/engine#11010) 2019-08-14 [email protected] [Windows] Alternative Windows shell platform implementation (flutter/engine#9835) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
Aug 15, 2019
Updates examples for flutter/engine#11010
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames all FLE* classes in the macOS embedding to Flutter*. With the exception
of -[FlutterDartProject engineSwitches], which is very clearly called out in the
comment, the APIs should be stable at this point, so the marker prefix is no
longer needed.
This is a breaking change for macOS embedders, but going forward breaking
changes at the source level for the macOS API should now be rare.
Some of these classes will likely merge with the iOS versions in the future (e.g.,
FlutterDartProject), but that will be an implementation detail that will not affect
clients.
Fixes flutter/flutter#31735