This repository was archived by the owner on Feb 25, 2025. It is now read-only.
On iOS report the preferred frames per second to tools via service protocol. #11006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Reporting on Android was wired up by @liyuqian in this patch. |
liyuqian
approved these changes
Aug 14, 2019
Contributor
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
LGTM.
Bonus point (probably for the future): is it possible to use the Firebase lab to test this (either in presubmit or postsubmit checks)? For example, iPad Pro should return 120 while others should return 60. CC @dnfield
Contributor
|
Looks like it should be possible -firebase has those devices. I haven't touched the iOS side much yet though (for example, we're running some tests on the simulator now that are not performance/'real device' sensitive) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 15, 2019
…rvice protocol. (flutter/engine#11006) (#38595) [email protected]:flutter/engine.git/compare/5e155c6c2d35...4c4c999 git log 5e155c6..4c4c999 --no-merges --oneline 2019-08-14 [email protected] On iOS report the preferred frames per second to tools via service protocol. (flutter/engine#11006) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.