Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Change SemanticsNode#children lists to be non-null #10952

Merged
mklim merged 2 commits into from
Aug 13, 2019
Merged

Change SemanticsNode#children lists to be non-null #10952

mklim merged 2 commits into from
Aug 13, 2019

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Aug 12, 2019 •
edited
Loading

Prevents NPEs and simplifies the code needed to handle these collections. There doesn't seem to have been a meaningful difference between null and empty collection here. The specific crash was happening when object.scrollChildren > 0 while object.childrenInHitTestOrder == null, which looks like it may be a bug on its own and probably needs further investigation.

I didn't see a useful test to add here because the loops were all happening deep within the implementation details of private helper methods. I could add a basic test on one of the public methods while I'm here just to add it, but it wouldn't really be related to this patch.

flutter/flutter#37886
flutter/flutter#30675

Change SemanticsNode#children lists to be non-null
769153a 
Fixes NPE crash reported when accessing them and simplifies the code
needed to handle them. There doesn't seem to be a meaningful difference
between null and empty collection here.
dnfield
dnfield reviewed Aug 12, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than what we have right now, but we probably want some kind of debug check for the case where scrollChildren > 0 and childrenInHitTestOrder is empty. Can we add that as part of this?

@mklim
Copy link
Contributor Author

mklim commented Aug 12, 2019

I think this is better than what we have right now, but we probably want some kind of debug check for the case where scrollChildren > 0 and childrenInHitTestOrder is empty. Can we add that as part of this?

Done.

@dnfield
Copy link
Contributor

dnfield commented Aug 12, 2019

Any thoughts on how we could test this?

@mklim
Copy link
Contributor Author

mklim commented Aug 12, 2019 •
edited
Loading

Any thoughts on how we could test this?

I don't think this change is really meaningfully testable in the class' current form. The code changes I've made are all implementation detail changes in private methods buried a few layers deep. SemanticsNode itself is a private class. I could refactor A11yBridge.java to be more testable and then test this if we're okay with making this a slightly riskier change. I'd probably start by breaking SemanticsNode out into its own package-private class and then I could probably test the member more directly from there, or alternatively tear the NPE problem area out into its own utility method that I could put under test. I'm not a huge fan of changing class surfaces just for the sake of testing them either, but this is a 2100 LOC class and could probably stand to be broken up some on its own anyway. WDYT?

dnfield
dnfield approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should probably come up with a strategy for testing this class, but this should resolve some hard crashers into something that we can get better debugging on now.

@mklim mklim merged commit ed88d0a into flutter:master Aug 13, 2019
@mklim mklim deleted the a11y_bridge_npe branch August 13, 2019 00:17
@mklim mklim mentioned this pull request Aug 13, 2019
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
0188711 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
ec7f9a9 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
28b8896 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
7f97af0 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
a72eeb8 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
836ddca 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
99c3c99 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
7e09b40 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
0445b32 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
ba55dfd 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
fd38d2f 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
9db6707 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
7cf16e3 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
6618df5 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
0b5d951 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
7b518f5 
…ngine#10952)
@matthew-carroll
Copy link
Contributor

matthew-carroll commented Aug 13, 2019

LGTM. I'd say as we go into classes like this, even adding a few tests around the most basic public behavior would allow us to begin chipping away at the technical debt, even if those tests don't exercise the code that was changed.

engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
Roll engine ff49ca1..7dfdfc6 (52 commits) (#38413)
54439bf 
[email protected]:flutter/engine.git/compare/ff49ca1c6e5b...7dfdfc6

git log ff49ca1..7dfdfc6 --no-merges --oneline
2019-08-13 [email protected] Roll src/third_party/skia b875cc709c7f..f99631100372 (2 commits) (flutter/engine#10974)
2019-08-13 [email protected] Roll src/third_party/dart 06509e333d..9aea1f3489 (8 commits)
2019-08-13 [email protected] Expose isolateId for engine (flutter/engine#10823)
2019-08-13 [email protected] Roll src/third_party/dart baebba06af..06509e333d (7 commits)
2019-08-13 [email protected] Roll fuchsia/sdk/core/linux-amd64 from u8FN9... to z99ul... (flutter/engine#10972)
2019-08-13 [email protected] Roll src/third_party/skia ef0406f04761..b875cc709c7f (4 commits) (flutter/engine#10970)
2019-08-13 [email protected] include zx::clock from new location to fix Fuchsia autoroll. (flutter/engine#10968)
2019-08-13 [email protected] Change SemanticsNode#children lists to be non-null (flutter/engine#10952)
2019-08-13 [email protected] Roll src/third_party/dart b31df28d72..baebba06af (5 commits)
2019-08-12 [email protected] Roll src/third_party/dart 896c053803..b31df28d72 (10 commits)
2019-08-12 [email protected] Increase the license block scan from 5k to 6k (flutter/engine#10956)
2019-08-12 [email protected] Fix format (flutter/engine#10955)
2019-08-12 [email protected] Roll src/third_party/skia 8d1b0bceedd6..ef0406f04761 (8 commits) (flutter/engine#10954)
2019-08-12 [email protected] Roll src/third_party/dart 32b70ce2a5..896c053803 (1 commits)
2019-08-12 [email protected] Fix iOS references to PostPrerollResult (flutter/engine#10949)
2019-08-12 [email protected] Allow for dynamic thread merging on IOS for embedded view mutations (flutter/engine#9819)
2019-08-12 [email protected] Report JUnit test failures (flutter/engine#10941)
2019-08-12 [email protected] Fix iOS keyboard crash (flutter/engine#10656)
2019-08-12 [email protected] Bump local podspec's iOS deployment target from 7.0 to 8.0 (flutter/engine#10662)
2019-08-12 [email protected] Roll src/third_party/skia c2da70fbef53..8d1b0bceedd6 (2 commits) (flutter/engine#10937)
2019-08-12 [email protected] Roll src/third_party/dart 9adf3c119e..32b70ce2a5 (3 commits)
2019-08-12 [email protected] iOS JIT support and enhancements for scenarios app (flutter/engine#10820)
2019-08-12 [email protected] Roll src/third_party/dart 261fd6266b..9adf3c119e (2 commits)
2019-08-12 [email protected] Roll src/third_party/skia da037b85352e..c2da70fbef53 (1 commits) (flutter/engine#10924)
2019-08-12 [email protected] Roll src/third_party/skia a47c48ef6bce..da037b85352e (3 commits) (flutter/engine#10909)
2019-08-12 [email protected] Roll src/third_party/dart e29d6d0ecb..261fd6266b (2 commits)
2019-08-12 [email protected] Roll src/third_party/skia 9c23a9e790b2..a47c48ef6bce (1 commits) (flutter/engine#10896)
2019-08-11 [email protected] Roll src/third_party/skia 5e7271a4598e..9c23a9e790b2 (1 commits) (flutter/engine#10838)
2019-08-11 [email protected] Roll src/third_party/skia 3e7fa79f2c79..5e7271a4598e (1 commits) (flutter/engine#10827)
2019-08-10 [email protected] Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826)
2019-08-10 [email protected] Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825)
2019-08-10 [email protected] Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824)
2019-08-10 [email protected] Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822)
2019-08-10 [email protected] Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits)
2019-08-10 [email protected] Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819)
2019-08-10 [email protected] Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits)
2019-08-09 [email protected] Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810)
2019-08-09 [email protected] Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812)
2019-08-09 [email protected] Revert "Remove flutter_kernel_sdk dart script (#10808)" (flutter/engine#10811)
2019-08-09 [email protected] [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809)
2019-08-09 [email protected] Remove flutter_kernel_sdk dart script (flutter/engine#10808)
2019-08-09 [email protected] change add part to add child (flutter/engine#10787)
2019-08-09 [email protected] rename stub_ui to web_ui (flutter/engine#10776)
2019-08-09 [email protected] [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700)
2019-08-09 [email protected] Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807)
...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
ad7a1f7 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
6cb5d72 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
35e6342 
…ngine#10952)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019
@engine-flutter-autoroll
ed88d0a Change SemanticsNode#children lists to be non-null (flutter/e…
49984dd 
…ngine#10952)
stuartmorgan-g added a commit to stuartmorgan-g/flutter that referenced this pull request Aug 13, 2019
@stuartmorgan-g
Roll engine ff49ca1..be4c833 (61 commits)
0360b44 
flutter/engine@be4c8338a Roll src/third_party/dart 20407e28db..45f892df68 (2 commits)
flutter/engine@da352d0f7 Revert "Track detailed LibTxt metrics with LineMetrics(flutter/engine#10127)" (flutter/engine#10982)
flutter/engine@23700fc1e Roll src/third_party/dart b9217efc77..20407e28db (6 commits)
flutter/engine@07f2cfa0e Roll src/third_party/skia 6e1b7bb2b5df..cd8b6d5c1cb8 (10 commits) (flutter/engine#10980)
flutter/engine@7711efbf0 Return an empty mapping for an empty file asset (flutter/engine#10815)
flutter/engine@663f9a9e1 Roll src/third_party/skia 6ef31815a694..6e1b7bb2b5df (1 commits) (flutter/engine#10979)
flutter/engine@0a0a14202 Roll fuchsia/sdk/core/linux-amd64 from z99ul... to j8BvV... (flutter/engine#10978)
flutter/engine@e13df85ce Roll src/third_party/dart 9aea1f3489..b9217efc77 (7 commits)
flutter/engine@d0698f275 Roll src/third_party/skia f99631100372..6ef31815a694 (3 commits) (flutter/engine#10976)
flutter/engine@7dfdfc6fa Roll src/third_party/skia b875cc709c7f..f99631100372 (2 commits) (flutter/engine#10974)
flutter/engine@274659564 Roll src/third_party/dart 06509e333d..9aea1f3489 (8 commits)
flutter/engine@e22893966 Expose isolateId for engine (flutter/engine#10823)
flutter/engine@a18fa3722 Roll src/third_party/dart baebba06af..06509e333d (7 commits)
flutter/engine@5909cf930 Roll fuchsia/sdk/core/linux-amd64 from u8FN9... to z99ul... (flutter/engine#10972)
flutter/engine@144007da5 Roll src/third_party/skia ef0406f04761..b875cc709c7f (4 commits) (flutter/engine#10970)
flutter/engine@6a4dfa7aa include zx::clock from new location to fix Fuchsia autoroll. (flutter/engine#10968)
flutter/engine@ed88d0a44 Change SemanticsNode#children lists to be non-null (flutter/engine#10952)
flutter/engine@853464e36 Roll src/third_party/dart b31df28d72..baebba06af (5 commits)
flutter/engine@fb317b085 Roll src/third_party/dart 896c053803..b31df28d72 (10 commits)
flutter/engine@20b7ea234 Increase the license block scan from 5k to 6k (flutter/engine#10956)
flutter/engine@a438469aa Fix format (flutter/engine#10955)
flutter/engine@70dd606ba Roll src/third_party/skia 8d1b0bceedd6..ef0406f04761 (8 commits) (flutter/engine#10954)
flutter/engine@cff3f3d66 Roll src/third_party/dart 32b70ce2a5..896c053803 (1 commits)
flutter/engine@b5c198b69 Fix iOS references to PostPrerollResult (flutter/engine#10949)
flutter/engine@971a63915 Allow for dynamic thread merging on IOS for embedded view mutations (flutter/engine#9819)
flutter/engine@c92a0d992 Report JUnit test failures (flutter/engine#10941)
flutter/engine@e95125aad Fix iOS keyboard crash (flutter/engine#10656)
flutter/engine@a50ec07d5 Bump local podspec's iOS deployment target from 7.0 to 8.0 (flutter/engine#10662)
flutter/engine@0ce28b100 Roll src/third_party/skia c2da70fbef53..8d1b0bceedd6 (2 commits) (flutter/engine#10937)
flutter/engine@07ee128c2 Roll src/third_party/dart 9adf3c119e..32b70ce2a5 (3 commits)
flutter/engine@79c50123a iOS JIT support and enhancements for scenarios app (flutter/engine#10820)
flutter/engine@d3be62888 Roll src/third_party/dart 261fd6266b..9adf3c119e (2 commits)
flutter/engine@68b749624 Roll src/third_party/skia da037b85352e..c2da70fbef53 (1 commits) (flutter/engine#10924)
flutter/engine@d3523b9b7 Roll src/third_party/skia a47c48ef6bce..da037b85352e (3 commits) (flutter/engine#10909)
flutter/engine@b39019d57 Roll src/third_party/dart e29d6d0ecb..261fd6266b (2 commits)
flutter/engine@19f564acf Roll src/third_party/skia 9c23a9e790b2..a47c48ef6bce (1 commits) (flutter/engine#10896)
flutter/engine@4099cb146 Roll src/third_party/skia 5e7271a4598e..9c23a9e790b2 (1 commits) (flutter/engine#10838)
flutter/engine@a3fa41b3b Roll src/third_party/skia 3e7fa79f2c79..5e7271a4598e (1 commits) (flutter/engine#10827)
flutter/engine@99355b086 Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826)
flutter/engine@8a068a1bd Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825)
flutter/engine@ee6267d04 Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824)
flutter/engine@7ad538dcc Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822)
flutter/engine@cbc2fe6e1 Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits)
flutter/engine@0afba6b1f Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819)
flutter/engine@6c678bfca Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits)
flutter/engine@03caa67ac Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810)
flutter/engine@e096f7830 Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812)
flutter/engine@cb1628986 Revert "Remove flutter_kernel_sdk dart script (flutter/engine#10808)" (flutter/engine#10811)
flutter/engine@42afb1abb [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809)
flutter/engine@1b287524e Remove flutter_kernel_sdk dart script (flutter/engine#10808)
flutter/engine@58f4f27a4 change add part to add child (flutter/engine#10787)
flutter/engine@708fc625d rename stub_ui to web_ui (flutter/engine#10776)
flutter/engine@70de3ec2c [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700)
flutter/engine@e0beaff61 Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807)
flutter/engine@83b640d4b Rename flutter_java.jar and flutter_engine.jar so they match the Maven comvention (flutter/engine#10797)
flutter/engine@c5d3c90d9 Roll fuchsia/sdk/core/linux-amd64 from 9xVXx... to HsuAH... (flutter/engine#10806)
flutter/engine@97326b242 Roll src/third_party/dart 3d9a356f6e..78ce916d82 (7 commits)
flutter/engine@086c0d50e Roll src/third_party/skia b2151310068b..26cedb4c603b (1 commits) (flutter/engine#10804)
flutter/engine@1c75ee7c0 Roll src/third_party/skia 059bf776c184..b2151310068b (3 commits) (flutter/engine#10803)
flutter/engine@2611a6eef Roll src/third_party/dart f29f41f1a5..3d9a356f6e (65 commits)
flutter/engine@09a05f8b9 Roll src/third_party/skia 4d557e3df433..059bf776c184 (1 commits) (flutter/engine#10801)
@stuartmorgan-g stuartmorgan-g mentioned this pull request Aug 13, 2019
Merged
9 tasks
stuartmorgan-g added a commit to flutter/flutter that referenced this pull request Aug 13, 2019
@stuartmorgan-g
Roll engine ff49ca1..be4c833 (61 commits) (#38495)
cde2784 
flutter/engine@be4c8338a Roll src/third_party/dart 20407e28db..45f892df68 (2 commits)
flutter/engine@da352d0f7 Revert "Track detailed LibTxt metrics with LineMetrics(flutter/engine#10127)" (flutter/engine#10982)
flutter/engine@23700fc1e Roll src/third_party/dart b9217efc77..20407e28db (6 commits)
flutter/engine@07f2cfa0e Roll src/third_party/skia 6e1b7bb2b5df..cd8b6d5c1cb8 (10 commits) (flutter/engine#10980)
flutter/engine@7711efbf0 Return an empty mapping for an empty file asset (flutter/engine#10815)
flutter/engine@663f9a9e1 Roll src/third_party/skia 6ef31815a694..6e1b7bb2b5df (1 commits) (flutter/engine#10979)
flutter/engine@0a0a14202 Roll fuchsia/sdk/core/linux-amd64 from z99ul... to j8BvV... (flutter/engine#10978)
flutter/engine@e13df85ce Roll src/third_party/dart 9aea1f3489..b9217efc77 (7 commits)
flutter/engine@d0698f275 Roll src/third_party/skia f99631100372..6ef31815a694 (3 commits) (flutter/engine#10976)
flutter/engine@7dfdfc6fa Roll src/third_party/skia b875cc709c7f..f99631100372 (2 commits) (flutter/engine#10974)
flutter/engine@274659564 Roll src/third_party/dart 06509e333d..9aea1f3489 (8 commits)
flutter/engine@e22893966 Expose isolateId for engine (flutter/engine#10823)
flutter/engine@a18fa3722 Roll src/third_party/dart baebba06af..06509e333d (7 commits)
flutter/engine@5909cf930 Roll fuchsia/sdk/core/linux-amd64 from u8FN9... to z99ul... (flutter/engine#10972)
flutter/engine@144007da5 Roll src/third_party/skia ef0406f04761..b875cc709c7f (4 commits) (flutter/engine#10970)
flutter/engine@6a4dfa7aa include zx::clock from new location to fix Fuchsia autoroll. (flutter/engine#10968)
flutter/engine@ed88d0a44 Change SemanticsNode#children lists to be non-null (flutter/engine#10952)
flutter/engine@853464e36 Roll src/third_party/dart b31df28d72..baebba06af (5 commits)
flutter/engine@fb317b085 Roll src/third_party/dart 896c053803..b31df28d72 (10 commits)
flutter/engine@20b7ea234 Increase the license block scan from 5k to 6k (flutter/engine#10956)
flutter/engine@a438469aa Fix format (flutter/engine#10955)
flutter/engine@70dd606ba Roll src/third_party/skia 8d1b0bceedd6..ef0406f04761 (8 commits) (flutter/engine#10954)
flutter/engine@cff3f3d66 Roll src/third_party/dart 32b70ce2a5..896c053803 (1 commits)
flutter/engine@b5c198b69 Fix iOS references to PostPrerollResult (flutter/engine#10949)
flutter/engine@971a63915 Allow for dynamic thread merging on IOS for embedded view mutations (flutter/engine#9819)
flutter/engine@c92a0d992 Report JUnit test failures (flutter/engine#10941)
flutter/engine@e95125aad Fix iOS keyboard crash (flutter/engine#10656)
flutter/engine@a50ec07d5 Bump local podspec's iOS deployment target from 7.0 to 8.0 (flutter/engine#10662)
flutter/engine@0ce28b100 Roll src/third_party/skia c2da70fbef53..8d1b0bceedd6 (2 commits) (flutter/engine#10937)
flutter/engine@07ee128c2 Roll src/third_party/dart 9adf3c119e..32b70ce2a5 (3 commits)
flutter/engine@79c50123a iOS JIT support and enhancements for scenarios app (flutter/engine#10820)
flutter/engine@d3be62888 Roll src/third_party/dart 261fd6266b..9adf3c119e (2 commits)
flutter/engine@68b749624 Roll src/third_party/skia da037b85352e..c2da70fbef53 (1 commits) (flutter/engine#10924)
flutter/engine@d3523b9b7 Roll src/third_party/skia a47c48ef6bce..da037b85352e (3 commits) (flutter/engine#10909)
flutter/engine@b39019d57 Roll src/third_party/dart e29d6d0ecb..261fd6266b (2 commits)
flutter/engine@19f564acf Roll src/third_party/skia 9c23a9e790b2..a47c48ef6bce (1 commits) (flutter/engine#10896)
flutter/engine@4099cb146 Roll src/third_party/skia 5e7271a4598e..9c23a9e790b2 (1 commits) (flutter/engine#10838)
flutter/engine@a3fa41b3b Roll src/third_party/skia 3e7fa79f2c79..5e7271a4598e (1 commits) (flutter/engine#10827)
flutter/engine@99355b086 Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826)
flutter/engine@8a068a1bd Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825)
flutter/engine@ee6267d04 Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824)
flutter/engine@7ad538dcc Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822)
flutter/engine@cbc2fe6e1 Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits)
flutter/engine@0afba6b1f Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819)
flutter/engine@6c678bfca Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits)
flutter/engine@03caa67ac Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810)
flutter/engine@e096f7830 Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812)
flutter/engine@cb1628986 Revert "Remove flutter_kernel_sdk dart script (flutter/engine#10808)" (flutter/engine#10811)
flutter/engine@42afb1abb [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809)
flutter/engine@1b287524e Remove flutter_kernel_sdk dart script (flutter/engine#10808)
flutter/engine@58f4f27a4 change add part to add child (flutter/engine#10787)
flutter/engine@708fc625d rename stub_ui to web_ui (flutter/engine#10776)
flutter/engine@70de3ec2c [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700)
flutter/engine@e0beaff61 Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807)
flutter/engine@83b640d4b Rename flutter_java.jar and flutter_engine.jar so they match the Maven comvention (flutter/engine#10797)
flutter/engine@c5d3c90d9 Roll fuchsia/sdk/core/linux-amd64 from 9xVXx... to HsuAH... (flutter/engine#10806)
flutter/engine@97326b242 Roll src/third_party/dart 3d9a356f6e..78ce916d82 (7 commits)
flutter/engine@086c0d50e Roll src/third_party/skia b2151310068b..26cedb4c603b (1 commits) (flutter/engine#10804)
flutter/engine@1c75ee7c0 Roll src/third_party/skia 059bf776c184..b2151310068b (3 commits) (flutter/engine#10803)
flutter/engine@2611a6eef Roll src/third_party/dart f29f41f1a5..3d9a356f6e (65 commits)
flutter/engine@09a05f8b9 Roll src/third_party/skia 4d557e3df433..059bf776c184 (1 commits) (flutter/engine#10801)
@mklim mklim mentioned this pull request Oct 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amirh amirh Awaiting requested review from amirh

@matthew-carroll matthew-carroll Awaiting requested review from matthew-carroll

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mklim @dnfield @matthew-carroll @googlebot