Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Aug 8, 2019

  • Allow for BSD formatting where the conditions are not bulleted or
    indented in any way.
  • Add support for Bison, which uses a modifed GPL license with an
    exception that allows distributing under "terms of your choice" when
    the larger work is not itself a parser-generator based on it.

- Increase parsed range; one file has a large changelog before the
  license, which pushes it slightly past the old range.
- Allow for BSD formatting where the conditions are not bulleted or
  indented in any way.
- Add support for Bison, which uses a modifed GPL license with an
  exception that allows distributing under "terms of your choice" when
  the larger work is not itself a parser-generator based on it.
@stuartmorgan-g
Copy link
Contributor Author

This is part of unblocking the new Windows embedding, but it seems much cleaner to have in a separate patch that lands first, rather than making it part of that already-large patch.

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Aug 9, 2019

I'm confused as to why this change appears to have moved the OpenSSL output in the golden files; any thoughts? And if it is just moved (I haven't done a line-by-line comparison yet to see if there are non-move changes) should we just update it and not worry about it?
Resolved in #10956.

stuartmorgan-g added a commit that referenced this pull request Aug 12, 2019
Split out of #10782 since it affects the detection of the license blocks of some files in third_party/boringssl.
@stuartmorgan-g
Copy link
Contributor Author

This is now ready for review; the change that caused boringssl output churn was split off and landed separately.

@stuartmorgan-g stuartmorgan-g requested a review from Hixie August 12, 2019 23:46
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@stuartmorgan-g stuartmorgan-g merged commit 3c37d73 into flutter:master Aug 14, 2019
@stuartmorgan-g stuartmorgan-g deleted the license-script-angle-support branch August 14, 2019 03:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 14, 2019
…38507)

[email protected]:flutter/engine.git/compare/fec1c92f8fc9...3c37d73

git log fec1c92..3c37d73 --no-merges --oneline
2019-08-14 [email protected] Update license script to handle ANGLE (flutter/engine#10782)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants