This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add #else, #endif condition comments #10477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few missing condition hints on some preprocessor conditionals.
Member
Author
|
Spotted while migrating to the public SDK tracing APIs. |
chinmaygarde
approved these changes
Aug 2, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2019
This was referenced Aug 3, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2019
[email protected]:flutter/engine.git/compare/bd988f6cc3d0...9605017 git log bd988f6..9605017 --no-merges --oneline 2019-08-03 [email protected] Reland Skia Caching improvements (flutter/engine#10434) 2019-08-02 [email protected] Delete unused create_macos_gen_snapshot.py script (flutter/engine#10479) 2019-08-02 [email protected] Add #else, #endif condition comments (flutter/engine#10477) 2019-08-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from eAnGy... to Mzwf3... (flutter/engine#10476) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Aug 8, 2019
Adds a few missing condition hints on some preprocessor conditionals.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few missing condition hints on some preprocessor conditionals.