This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Disable windows tests" #10146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0861e0a.
Contributor
Author
|
Looks like we're green again, re-enabling these. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 26, 2019
flutter/engine@0861e0a...d8c9b10 git log 0861e0a..d8c9b10 --no-merges --oneline d8c9b10 [fucshia] fix name to reflect the cmx file (flutter/engine#10151) 3388781 Revert "Disable windows tests (#10143)" (flutter/engine#10146) ae5e611 Roll src/third_party/skia fff996c117c1..04aa81ae66bc (32 commits) (flutter/engine#10149) a6038d5 Roll fuchsia/sdk/core/linux-amd64 from ylNwUxj7tBGga6sghqrKH_gqu3RzfTLxB4rxZhAk2IAC to vHQ3m9W_pv1OLg6ch-uP3bu-VhWS-4PKZm4YrxjP-fAC (flutter/engine#10148) 5edd787 [fuchsia] Push CMX to fars and add product mode support (flutter/engine#10144) 70c8c3f Roll fuchsia/sdk/core/mac-amd64 from SHb_OsdvSz75N-G-jbG-tQOM1OyipLcQG0rsVrARsX0C to giU1d8T7pC6K7vuX0_0ZQpH_ZkzIbgvyao2ICAW6PS8C (flutter/engine#10147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@0861e0a...d8c9b10 git log 0861e0a..d8c9b10 --no-merges --oneline d8c9b10 [fucshia] fix name to reflect the cmx file (flutter/engine#10151) 3388781 Revert &flutter#34;Disable windows tests (flutter#10143)&flutter#34; (flutter/engine#10146) ae5e611 Roll src/third_party/skia fff996c117c1..04aa81ae66bc (32 commits) (flutter/engine#10149) a6038d5 Roll fuchsia/sdk/core/linux-amd64 from ylNwUxj7tBGga6sghqrKH_gqu3RzfTLxB4rxZhAk2IAC to vHQ3m9W_pv1OLg6ch-uP3bu-VhWS-4PKZm4YrxjP-fAC (flutter/engine#10148) 5edd787 [fuchsia] Push CMX to fars and add product mode support (flutter/engine#10144) 70c8c3f Roll fuchsia/sdk/core/mac-amd64 from SHb_OsdvSz75N-G-jbG-tQOM1OyipLcQG0rsVrARsX0C to giU1d8T7pC6K7vuX0_0ZQpH_ZkzIbgvyao2ICAW6PS8C (flutter/engine#10147) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10143 These look like they might be working agian.