This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Use the patched sdk to generate the flutter jit runner far #10122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Jul 24, 2019
| @@ -1,163 +1,160 @@ | |||
| { | |||
| "comment:0": "NOTE: THIS FILE IS GENERATED. DO NOT EDIT.", | |||
Contributor
There was a problem hiding this comment.
Should we remove this line? Is it true anymore?
Contributor
Author
There was a problem hiding this comment.
yeah, we can still generate this using libraries.yaml i haven't verified, but in theory it should just work.
Contributor
Author
There was a problem hiding this comment.
fwiw, i've also committed the changes to libraries.yaml in this PR
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2019
flutter/engine@72341ed...89142b5 git log 72341ed..89142b5 --no-merges --oneline 89142b5 Roll fuchsia/sdk/core/linux-amd64 from RfQgXVCVII4_oiWfVIkIMMVepj5wklCOhiClVRyYNucC to NrExSKBKIhY3SnE4sD0-vHjEMCBYYffzarRM2rWONUUC (flutter/engine#10131) 44cf59c Roll fuchsia/sdk/core/mac-amd64 from gvGDLzElkEmPrBTbtjW6rhPqr78z-b4ytTxE2k58CFAC to 9EcA--gzHNo80R_fAuB_Tq7ECubTP0Uz3UrycPIvRpsC (flutter/engine#10130) fcd6732 [fuchsia] Use the patched sdk to generate the flutter jit runner far (flutter/engine#10122) cfd43a1 Roll fuchsia/sdk/core/linux-amd64 from gTG1jp04GzBudVJqRxulXYOEQgbYTUQgnqLDYAq7z3sC to RfQgXVCVII4_oiWfVIkIMMVepj5wklCOhiClVRyYNucC (flutter/engine#10126) 936c74d Roll fuchsia/sdk/core/mac-amd64 from UCAnzi4k9pA30l_iZ2Ru51Tc3Ke6iacIdjFMgVUVdRMC to gvGDLzElkEmPrBTbtjW6rhPqr78z-b4ytTxE2k58CFAC (flutter/engine#10121) aaf6bad Fixed memory leak with engine registrars. (flutter/engine#10068) 4bf81b8 [fuchsia] Use manifest file to better replicate the existing build (flutter/engine#10102) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Jul 25, 2019
…ner far (flutter#10122)" This reverts commit fcd6732.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@72341ed...89142b5 git log 72341ed..89142b5 --no-merges --oneline 89142b5 Roll fuchsia/sdk/core/linux-amd64 from RfQgXVCVII4_oiWfVIkIMMVepj5wklCOhiClVRyYNucC to NrExSKBKIhY3SnE4sD0-vHjEMCBYYffzarRM2rWONUUC (flutter/engine#10131) 44cf59c Roll fuchsia/sdk/core/mac-amd64 from gvGDLzElkEmPrBTbtjW6rhPqr78z-b4ytTxE2k58CFAC to 9EcA--gzHNo80R_fAuB_Tq7ECubTP0Uz3UrycPIvRpsC (flutter/engine#10130) fcd6732 [fuchsia] Use the patched sdk to generate the flutter jit runner far (flutter/engine#10122) cfd43a1 Roll fuchsia/sdk/core/linux-amd64 from gTG1jp04GzBudVJqRxulXYOEQgbYTUQgnqLDYAq7z3sC to RfQgXVCVII4_oiWfVIkIMMVepj5wklCOhiClVRyYNucC (flutter/engine#10126) 936c74d Roll fuchsia/sdk/core/mac-amd64 from UCAnzi4k9pA30l_iZ2Ru51Tc3Ke6iacIdjFMgVUVdRMC to gvGDLzElkEmPrBTbtjW6rhPqr78z-b4ytTxE2k58CFAC (flutter/engine#10121) aaf6bad Fixed memory leak with engine registrars. (flutter/engine#10068) 4bf81b8 [fuchsia] Use manifest file to better replicate the existing build (flutter/engine#10102) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.