This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macos] Revert check on FlutterCodecs and refactor message function] #10009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
suggested changes
Jul 22, 2019
| FlutterEngineResult result = FlutterEngineSendPlatformMessage(_engine, &platformMessage); | ||
| if (result != kSuccess) { | ||
| NSLog(@"Failed to send message to Flutter engine on channel '%@' (%d).", channel, result); | ||
| if (!callback) { |
Contributor
There was a problem hiding this comment.
This moves the code duplication into the same method, rather than removing it. We should have a single copy of the code that calls FlutterEngineSendPlatformMessage, checks the return value, and logs. The conditional part should be populating the reply in the message (and then cleaning it up).
| captures->reply = callback; | ||
| auto message_reply = [](const uint8_t* data, size_t data_size, void* user_data) { | ||
| auto captures = reinterpret_cast<Captures*>(user_data); | ||
| NSData* reply_data = [NSData dataWithBytes:(void*)data length:data_size]; |
Contributor
There was a problem hiding this comment.
Sorry, missed this: use static_cast, not a C-style cast.
stuartmorgan-g
approved these changes
Jul 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
This was referenced Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
This was referenced Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
This was referenced Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2019
Member
|
This broke channels_integration_test_ios test on flutter engine roll. |
Contributor
|
It looks like the FlutterCodecs.mm change was restoring the old behavior, but the FlutterChannels.mm change isn't; I missed that in review. Maybe that's the reason for failures. Do you have links to the failure details? |
Member
|
Given that those are flutter build dashboard failures you should be able to get to the logs from https://flutter-dashboard.appspot.com/build.html for red box on channels_integration_test_ios column. |
franciscojma86
added a commit
to franciscojma86/engine
that referenced
this pull request
Jul 25, 2019
…nction] (flutter#10009)" This reverts commit bd38702.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.