Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fc59272
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0593c04
Choose a head ref
  • 4 commits
  • 13 files changed
  • 3 contributors

Commits on Aug 27, 2023

  1. [Impeller] Implement TextDecoration (i.e. dashed lines) (#45041) 

    Closes flutter/flutter#126673.

Ideally, this would be an `#ifdef`, but currently Impeller is a runtime
flag, for reasons (CI capacity?)

~~To be able to write tests, I'd need
flutter/flutter#133264 completed.~~ Edit:


![life-uh](https://github.com/flutter/engine/assets/168174/c77314e4-f3f9-4b0d-b3f7-5b070ef51308)

## Before

![Screenshot 2023-08-23 at 5 25 40
PM](https://github.com/flutter/engine/assets/168174/40576807-17f2-4f5f-ba56-3cd5771e472d)

## After

<img width="795" alt="Screenshot 2023-08-24 at 9 56 48 AM"
src="https://github.com/flutter/engine/assets/168174/0e33f705-6a71-4468-8ec8-372a2e98624e">
    @matanlurey
    matanlurey authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    43e9683 View commit details
    Browse the repository at this point in the history

  2. Use YAML >- to avoid strange formatting. (#45158) 

    Partial (safe) re-land of #44936.
    @matanlurey
    matanlurey authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    1e29989 View commit details
    Browse the repository at this point in the history

  3. [Impeller] SuboptimalKHR is not an exit condition. (#45157) 

    Sometimes we can get SuboptimalKHR on swapchain aquisition, and if we dont treat that as success the app will exit.
    Jonah Williams authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    c1b2ef0 View commit details
    Browse the repository at this point in the history

  4. Roll Fuchsia Linux SDK from N-A8agqDgvTKiT2Wc... to jnDJLdEAx34diOWFx… 

    …... (#45159)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    0593c04 View commit details
    Browse the repository at this point in the history
Loading