Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f828363
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ad1343c
Choose a head ref
  • 3 commits
  • 38 files changed
  • 3 contributors

Commits on Jun 28, 2024

  1. [Impeller] experimental canvas bdf support. (#53597) 

    Almost working bdf for experimentcal canvas.

Currently there are some problems with the clip depth, and positioning of the backdrop filter. I think I am not taking the blur transform into account at the very least.

FYI @bdero
    Jonah Williams authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b6f6e1d View commit details
    Browse the repository at this point in the history

  2. Reland [DisplayList] Add support for clipOval to leverage Impeller op… 

    …timization (#53642)

Reland of #53622 that checks the inverse fill flag of the paths.
    @flar
    flar authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d6ee3ab View commit details
    Browse the repository at this point in the history

  3. [web] switch from .didGain/LoseAccessibilityFocus to .focus (#53360) 

    This is a repeat of #53134, which was merged prematurely.

> [!WARNING]  
> Only land this after:
> * flutter/flutter#149840 lands in the framework.
> * You have personally manually tested the change together with the latest framework on all browsers.

## Original PR description

Stop using `SemanticsAction.didGain/LoseAccessibilityFocus` on the web, start using `SemanticsAction.focus`. This is because on the web, a11y focus is not observable, only input focus is. Sending `SemanticsAction.focus` will guarantee that the framework move focus to the respective widget. There currently is no "unfocus" signal, because it seems to be already covered: either another widget gains focus, or an HTML DOM element outside the Flutter view does, both of which have their respective signals already.

More details in the discussion in the issue flutter/flutter#83809.

Fixes flutter/flutter#83809
Fixes flutter/flutter#148285
Fixes flutter/flutter#143337
    @yjbanov
    yjbanov authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ad1343c View commit details
    Browse the repository at this point in the history
Loading