Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5fbfa8
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3fff731
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Jul 25, 2023

  1. Reland "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (

    #43965)
    
    Relanding #43902 without the
    copy-pasta return statements which did not seem to cause a compile
    issue, but caused Fuchsia tests to hang.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I added new tests to check the change I am making or feature I am
    adding, or Hixie said the PR is test-exempt. See [testing the engine]
    for instructions on writing and running engine tests.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    kjlubick authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bb02f1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f873404 View commit details
    Browse the repository at this point in the history
  3. Manual roll Dart SDK from 8662af7d9aa3 to 61ab5422fb7b (12 revisions) (

    …#44007)
    
    Manual roll requested by [email protected]
    
    https://dart.googlesource.com/sdk.git/+log/8662af7d9aa3..61ab5422fb7b
    
    2023-07-25 [email protected] Version 3.1.0-345.0.dev
    2023-07-24 [email protected] Version 3.1.0-344.0.dev
    2023-07-24 [email protected] Version 3.1.0-343.0.dev
    2023-07-24 [email protected] Version 3.1.0-342.0.dev
    2023-07-23 [email protected] Version 3.1.0-341.0.dev
    2023-07-22 [email protected] Version 3.1.0-340.0.dev
    2023-07-22 [email protected] Version 3.1.0-339.0.dev
    2023-07-21 [email protected] Version 3.1.0-338.0.dev
    2023-07-21 [email protected] Version 3.1.0-337.0.dev
    2023-07-21 [email protected] Version 3.1.0-336.0.dev
    2023-07-21 [email protected] Version 3.1.0-335.0.dev
    2023-07-21 [email protected] Version 3.1.0-334.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    de8c272 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3fff731 View commit details
    Browse the repository at this point in the history
Loading