Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f23cc4d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b686508
Choose a head ref
  • 4 commits
  • 21 files changed
  • 2 contributors

Commits on Apr 23, 2024

  1. Roll Dart SDK from acd54f86bdbb to 6a670b60eb06 (1 revision) (#52327) 

    https://dart.googlesource.com/sdk.git/+log/acd54f86bdbb..6a670b60eb06

2024-04-23 [email protected] Version 3.5.0-91.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    26befb4 View commit details
    Browse the repository at this point in the history

  2. [Impeller] drawVertices uber shader. (#52315) 

    In order to land #52303 , we need to finally fix the advanced blend draw vertices combo. Right now a ColorFilter is used for advanced blends which doesn't work if there are overlapping vertices.

See also: flutter/flutter#145707

The issue was fixed for drawVertices/drawAtlas pipeline blends using the porterduff shader. This extends this to advanced blends, but since drawVertices/atlas with an advanced blend is uncommon and  because we don't 15 new shader variants, just add one special uber shader.

Part of flutter/flutter#131345
    Jonah Williams authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b698b75 View commit details
    Browse the repository at this point in the history

  3. [Impeller] only use framebuffer advanced blends if available. (#52284) 

    This reduces the shader bootstrap count by 15.

Instead of using the regular advanced blend filters for BlendFilters, start a render pass and use the framebuffer advanced blend.

part of flutter/flutter#143540
    Jonah Williams authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c393b9f View commit details
    Browse the repository at this point in the history

  4. Roll Fuchsia Linux SDK from L533ubzhjWwW7jxbc... to le_-uFgRD5DjvvqgL… 

    …... (#52329)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b686508 View commit details
    Browse the repository at this point in the history
Loading