Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f2154ef
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bb77cf8
Choose a head ref
  • 6 commits
  • 19 files changed
  • 4 contributors

Commits on Oct 31, 2024

  1. Refactor ArgParser.usage tests for BuildPlan to reduce duplicatio… 

    …n. (#56254)

Part of flutter/flutter#157870.

I figured I'd tackle a theme of tests at a time - easier for me to do in little spurts between other tasks.
    @matanlurey
    matanlurey authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a369482 View commit details
    Browse the repository at this point in the history

  2. Add timeout to local_engine. (#56271) 

    See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20local_engine_builds.
    @matanlurey
    matanlurey authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c056b18 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#… 

    …56221)

Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.

Fixes flutter/flutter#157113
    Jonah Williams authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    165e6ad View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (#56272) 

    https://skia.googlesource.com/skia.git/+log/3c628426f85f..9168ad248c69

2024-10-31 [email protected] [mac] Update build target to for x86 to be 10.15
2024-10-31 [email protected] Roll vulkan-deps from 1d891d46a65c to 37d41da69cc4 (2 revisions)
2024-10-31 [email protected] Revert "Add verb measurement utils to SkContourMeasure"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d0bf057 View commit details
    Browse the repository at this point in the history

  5. iOS,macOS: migrate shell/gpu to ARC (#56157) 

    Migrates Objective-C code in shell/gpu to ARC.

Migrate `sk_cfp::reset(__bridge_retained ptr)` to `sk_cfp::retain(__bridge ptr)`. `reset` `CFRelease`s the previously held pointer and sets the pointer to the new pointer. `retain` `CFRetain`s the new pointer prior to setting it.

No changes to tests since this makes no semantic changes.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a65f1d5 View commit details
    Browse the repository at this point in the history

  6. iOS: migrate Metal testing types to ARC (#56156) 

    This migrates Flutter's TestMetalContext and TestMetalSurface to ARC.

Also migrates to using `sk_cfp::retain` (which retains the passed in pointer) rather than `sk_cfp::reset`, which only releases the previous pointer but doesn't retain the incoming pointer.

No changes to tests since no semantic changes.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bb77cf8 View commit details
    Browse the repository at this point in the history
Loading