Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: effcf97
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d374c78
Choose a head ref
  • 5 commits
  • 10 files changed
  • 4 contributors

Commits on Mar 6, 2024

  1. [Impeller] Fix path winding when bridging from contours with an odd n… 

    …umber of points. (#51218)

If the previous contour has an odd number of points, insert a duplicate point to keep the winding order consistent across contours.

Before:

![Screenshot 2024-03-05 at 4 16 46�PM](https://github.com/flutter/engine/assets/919017/05306c92-78e9-4d16-88c1-6191d8ee1160)

After:

![Screenshot 2024-03-05 at 4 14 54�PM](https://github.com/flutter/engine/assets/919017/3743527f-d686-4c98-87f3-cb4db3c1a1ef)
    @bdero
    bdero authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f96ae0a View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (#51216) 

    https://skia.googlesource.com/skia.git/+log/37947aec8c5c..1d1fd7fe1a89

2024-03-05 [email protected] [graphite] Use internal class to manage DrawAtlas in SmallPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    01e88b4 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Enable depth buffer clipping & Stencil-then-Cover path ren… 

    …dering. (#51219)

Turn the page, wash your hands.

Addresses the following issues:
* flutter/flutter#143077
* flutter/flutter#137714
* flutter/flutter#138460
* flutter/flutter#123671
* flutter/flutter#141961
* flutter/flutter#134432

Previous attempts:
1. #50856
    - reverted with #51191
    - fixed with #51198
2. #51209
    - reverted with #51217
    - fixed with #51218
    @bdero
    bdero authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    85ab856 View commit details
    Browse the repository at this point in the history

  4. [Impeller] disable blending in gaussian intermediate steps. (#51118) 

    Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
    Jonah Williams authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    742c780 View commit details
    Browse the repository at this point in the history

  5. Revamp the scenario_app/../README.md to encourage self-sustenance (#… 

    …51196)

Feedback welcome, though if it is non-blocking and ambiguous consider a follow-up PR instead �
    @matanlurey
    matanlurey authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d374c78 View commit details
    Browse the repository at this point in the history
Loading