Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ecbb2b2
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bc885f3
Choose a head ref
  • 7 commits
  • 20 files changed
  • 3 contributors

Commits on Aug 4, 2018

  1. Roll src/third_party/skia 4c3b63e..71fe8ba (3 commits) (#5940)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 4, 2018
    Configuration menu
    Copy the full SHA
    aaf4a9a View commit details
    Browse the repository at this point in the history
  2. Roll src/third_party/skia 71fe8ba..59aabbc (1 commits) (#5942)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 4, 2018
    Configuration menu
    Copy the full SHA
    97aea09 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2018

  1. Roll src/third_party/skia 59aabbc..2e77f54 (1 commits) (#5943)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 5, 2018
    Configuration menu
    Copy the full SHA
    63ede2e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Replace acquire+release thread annotation with excludes (#5944)

    The behavior of acquire+release annotation handling has changed in
    https://reviews.llvm.org/D49355 which breaks the build with the new
    Clang. However, as has been pointed out, the acquire+release isn't
    the right way to prevent double locking as the annotations negate
    each other; the correct way is to use excludes or negative requires.
    Using excludes annotations also requires using std::lock_guard instead
    of std::unique_lock because the latter doesn't have the thread
    annotations due to deferred locking which is not needed in Flutter and
    so std::lock_guard is a sufficient alternative.
    petrhosek authored Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c6baaaf View commit details
    Browse the repository at this point in the history
  2. Roll src/third_party/skia 2e77f54..12fb9cf (1 commits) (#5945)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 6, 2018
    Configuration menu
    Copy the full SHA
    f4464a8 View commit details
    Browse the repository at this point in the history
  3. Roll src/third_party/skia 12fb9cf..6e487e6 (8 commits) (#5946)

    Auto-roller completed checks. Merging.
    skia-flutter-autoroll authored Aug 6, 2018
    Configuration menu
    Copy the full SHA
    5770cbd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bc885f3 View commit details
    Browse the repository at this point in the history
Loading