Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e91e4db
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 88cb78c
Choose a head ref
  • 11 commits
  • 34 files changed
  • 4 contributors

Commits on Nov 1, 2018

  1. Roll src/third_party/skia 763fc96..3bdaa46 (2 commits) (#6723) 

    https://skia.googlesource.com/skia.git/+log/763fc966993d..3bdaa46bff71


Created with:
  gclient setdep -r src/third_party/skia@3bdaa46bff71

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 1, 2018
    Configuration menu
    Copy the full SHA
    60d4d58 View commit details
    Browse the repository at this point in the history

  2. Roll src/third_party/skia 3bdaa46..f1eda00 (11 commits) (#6724) 

    https://skia.googlesource.com/skia.git/+log/3bdaa46bff71..f1eda00bf6b0


Created with:
  gclient setdep -r src/third_party/skia@f1eda00bf6b0

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 1, 2018
    Configuration menu
    Copy the full SHA
    d06ace6 View commit details
    Browse the repository at this point in the history

  3. Report asset names in loading trace events. (#6713)

    @rmacnak-google
    rmacnak-google authored Nov 1, 2018
    Configuration menu
    Copy the full SHA
    fbb7893 View commit details
    Browse the repository at this point in the history

  4. Roll src/third_party/skia f1eda00..e978ca2 (10 commits) (#6725) 

    https://skia.googlesource.com/skia.git/+log/f1eda00bf6b0..e978ca297965


Created with:
  gclient setdep -r src/third_party/skia@e978ca297965

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 1, 2018
    Configuration menu
    Copy the full SHA
    f3fcb8f View commit details
    Browse the repository at this point in the history

  5. Fixed typo (#6717) 

    In comments, replaced `...using using...` with just `...using...`
    @Maxim-Mazurok @jason-simmons
    Maxim-Mazurok authored and jason-simmons committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    c57d29a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. Roll src/third_party/skia e978ca2..94d7af7 (5 commits) (#6727) 

    https://skia.googlesource.com/skia.git/+log/e978ca297965..94d7af7bcc96


Created with:
  gclient setdep -r src/third_party/skia@94d7af7bcc96

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    1360556 View commit details
    Browse the repository at this point in the history

  2. Add an overlay surface on top of embedded UIViews. (#6726) 

    The overlay surfaces are going to be the same IOSSurface implementation
with the platform views controller set to null (so these are surfaces
that don't support embedding platform views to them).

  * Adds a FlutterOverlayView which is a UIView that's showing an
    overlay surface.
  * Creates an overlay surface for each embedded UIView (done in
    FlutterPlatformViewsController).
  * Changes CompositeEmbeddedView to return a new canvas.
  * Makes the PlatformViewLayer replace the PaintContext's canvas with
    the canvas for the overlay view.
  * Changed canvas in PaintContext to be a pointer so it can be changed.

TBD in following PRs:
  * Copy the current canvas state when replacing a canvas in PaintContext.
  * Make FlutterOverlayView work with a GL backend (currently it only
    works with software rendering)
    @amirh
    amirh authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    9e1f546 View commit details
    Browse the repository at this point in the history

  3. Roll src/third_party/skia 94d7af7..26fcd71 (5 commits) (#6729) 

    https://skia.googlesource.com/skia.git/+log/94d7af7bcc96..26fcd7166c74


Created with:
  gclient setdep -r src/third_party/skia@26fcd7166c74

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    10ec1fd View commit details
    Browse the repository at this point in the history

  4. Roll src/third_party/skia 26fcd71..2dc1e34 (2 commits) (#6730) 

    https://skia.googlesource.com/skia.git/+log/26fcd7166c74..2dc1e34f9029


Created with:
  gclient setdep -r src/third_party/skia@2dc1e34f9029

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    7618e54 View commit details
    Browse the repository at this point in the history

  5. Roll src/third_party/skia 2dc1e34..13853a1 (1 commits) (#6731) 

    https://skia.googlesource.com/skia.git/+log/2dc1e34f9029..13853a120d5a


Created with:
  gclient setdep -r src/third_party/skia@13853a120d5a

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    eacf61e View commit details
    Browse the repository at this point in the history

  6. Roll src/third_party/skia 13853a1..30edaaa (1 commits) (#6732) 

    https://skia.googlesource.com/skia.git/+log/13853a120d5a..30edaaac1da4


Created with:
  gclient setdep -r src/third_party/skia@30edaaac1da4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2018
    Configuration menu
    Copy the full SHA
    88cb78c View commit details
    Browse the repository at this point in the history
Loading