Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e51d4f1
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c807aea
Choose a head ref
  • 4 commits
  • 33 files changed
  • 3 contributors

Commits on Feb 17, 2024

  1. Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (#50739) 

    https://dart.googlesource.com/sdk.git/+log/fa66195a3814..6d659f880394

2024-02-17 [email protected] Version 3.4.0-154.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    b15871b View commit details
    Browse the repository at this point in the history

  2. [Impeller] Assign subpass depth on restore rather than creation. (#50626 

    )

The subpass depth is used for drawing the texture to the parent pass. So it needs a depth > all of the clips contained within the subpass.

Also correct the way we're assigning the depth value in shaders.
    @bdero
    bdero authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    0a7fcfc View commit details
    Browse the repository at this point in the history

  3. [Impeller] add additional setup method that caches more pipelines, wa… 

    …rms internal shader code (#50521)

Part of flutter/flutter#138236

Fixes a number of issues related to startup performance by adding an "InitializeCommonlyUsedShadersIfNeeded" method to content context.

On the first frame of a flutter application renders, the backend will populate the glyph atlas for the first time. On the Vulkan backend, this executes vkCmdCopyBufferToImage. The first time this runs, Arm Mali drivers will generate an additional shader program. Creates a 1x1 texture and sets the contents to force this code to compile eagerly.

![image](https://github.com/flutter/engine/assets/8975114/558e7680-77e1-4cec-94d2-17128f4c8865)

The first time a render pass is constructed, a shader is complied. This does not seem to depend on the properties of the render pass, so we just create a trivial one and submit it.

![image](https://github.com/flutter/engine/assets/8975114/4d9c9266-adfb-4d18-84cc-eb60127147ed)

Finally there are a few missing shader variants. Lets just go ahead a populate that cache a bit more
    Jonah Williams authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    be0f6aa View commit details
    Browse the repository at this point in the history

  4. Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (#50744) 

    https://skia.googlesource.com/skia.git/+log/bb61c2b4614e..0d2dbf53aef6

2024-02-17 [email protected] Roll vulkan-deps from a8bde474ad6e to 73413fef3ec0 (4 revisions)
2024-02-16 [email protected] SkWuffsCodec: Skip copying stream if PreferStillImage
2024-02-16 [email protected] Roll SK Tool from cfeca87ea13f to 80035da8ddde

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 17, 2024
    Configuration menu
    Copy the full SHA
    c807aea View commit details
    Browse the repository at this point in the history
Loading