Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e25e977
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ea848c3
Choose a head ref
  • 6 commits
  • 11 files changed
  • 5 contributors

Commits on Mar 12, 2024

  1. Fix null filter NOP case in DlLocalMatrixImageFilter (#51340) 

    The `DlLocalMatrixImageFilter` was returning null from the bounds methods when it had no filter to apply which violates the method contracts. It should have been setting the result rect to the argument rect and returning a valid pointer to meet the method contract.
    @flar
    flar authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b230278 View commit details
    Browse the repository at this point in the history

  2. [dart:ui] Add view ID to PointerData.toString (#51352) 

    The `view_id` is useful information as the pointer's `x` and `y` coordinates are relative to the view's origin.

Part of flutter/flutter#112205
Part of flutter/flutter#142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @loic-sharma
    loic-sharma authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b259127 View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from 7f26f32f374f to b19e0995f317 (1 revision) (#51363) 

    https://dart.googlesource.com/sdk.git/+log/7f26f32f374f..b19e0995f317

2024-03-12 [email protected] Version 3.4.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    093e381 View commit details
    Browse the repository at this point in the history

  4. [web] make addView/removeView functions sync (#51103) 

    Related to flutter/flutter#138930
    @p-mazhnik
    p-mazhnik authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8b3fa09 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 187488b64570 to bbe453e3525d (1 revision) (#51366) 

    https://skia.googlesource.com/skia.git/+log/187488b64570..bbe453e3525d

2024-03-12 [email protected] Roll vulkan-deps from 804247a574ea to 6b4cf4e2ca6b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e3f3c02 View commit details
    Browse the repository at this point in the history

  6. Fix some races in the platform isolate tests (#51358) 

    * Do not check IsolateIsShutdown after CreateAndRegisterIsolate in the MultithreadedCreation test.

The test's main thread could run ShutdownPlatformIsolates between a worker thread's calls to CreateAndRegisterIsolate and IsolateIsShutdown.  If that happens, IsolateIsShutdown will return true even though CreateAndRegisterIsolate succeeded.

* Change the is_registered flag to was_registered and do not clear it during isolate shutdown

Tests like MultithreadedCreation need to know whether RegisterPlatformIsolate succeeded so they can determine if the isolate will be shut down by ShutdownPlatformIsolates or if it needs to be shut down explicitly.  If the flag is cleared during shutdown, then the test may see an isolate that was successfully registered and shut down and think that it was never registered.
    @jason-simmons
    jason-simmons authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ea848c3 View commit details
    Browse the repository at this point in the history
Loading