Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d00b69a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 489c399
Choose a head ref
  • 3 commits
  • 26 files changed
  • 3 contributors

Commits on Sep 1, 2023

  1. Reland "ios: remove shared_application and support app extension build … 

    …#44732" (#45351)

Relands #44732 with fix. 

The original PR returns nil when the assets is not reachable, in some cases, the assets are not loaded yet but will be loaded later, so we should return the asset URL regardless. 

Also added a fallback to main bundle to match the previous implementation. 

The original PR was failed in internal tests in b/297654739
Now with the fix, all tests passed: cl/561449914

fixes flutter/flutter#124289

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9446392 View commit details
    Browse the repository at this point in the history

  2. [Impeller] EntityPass::Clone needs to clone harder (#45313) 

    Fixes flutter/flutter#133731
    Jonah Williams authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    66e53ee View commit details
    Browse the repository at this point in the history

  3. Update (flipping the default from false -> true) and deprecate Paint.… 

    …enableDithering. (#44705)

Update: Blocked on #44912 landing,
and merging into google3.

---

Partial work towards flutter/flutter#112498.

_**tl;dr**: In Impeller's backend we intend to _always_ dither
gradients, and never allow any changes long-term (i.e., write your own
shader if you want different behavior) with the assumption that dithered
gradients look better most of the time, and don't typically hurt
elsewhere._

Note that, at the time of this writing, I couldn't find a single case of
this being set explicitly to `true` inside Google, and there are between
[100 and 200 publicly accessible on
GitHub](https://github.com/search?q=%22Paint.enableDithering%22+language%3ADart&type=code&l=Dart),
of which virtually all are setting it explicitly to `true`.

There are some (valid) concerns this would cause a lot of golden-file
image diffs, so I'm going to seek explicit approval from the Google
testing team as well as someone from the framework team before landing
this commit.
    @matanlurey
    matanlurey authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    489c399 View commit details
    Browse the repository at this point in the history
Loading