Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ca8cf6b
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c24f303
Choose a head ref
  • 3 commits
  • 14 files changed
  • 3 contributors

Commits on Oct 16, 2023

  1. [Impeller] Adjust clip coverage operations to handle per-pass clip st… 

    …acks (#46912)

#46597 creates a new clip coverage stack for each subpass.  This PR updates some clip coverage operations and assertions in EntityPass::OnRender to reflect that the current clip coverage stack only contains the range of depths within the current subpass.
    @jason-simmons
    jason-simmons authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    172ad1f View commit details
    Browse the repository at this point in the history

  2. [Impeller] implements a retry mechanism for dart:ui/Image.toByteData. (… 

    …#46840)

Design doc: [link](https://docs.google.com/document/d/1Uuiw3pdQxNFTA8OQuZ-kuvYg1NB42XgccQCZeqr4oII/edit#heading=h.hn6wreyrz6fm)
fixes: flutter/flutter#135245

One slight deviation from the design doc is that I decided to make ContextMTL respond to changes to the SyncSwitch instead of having it observe the app state directly.  The benefits are:
1) This keeps that functionality in one location
1) It makes writing tests much easier
1) There's no need of conditional compilation between macos and ios
1) There is no need to add an objc class

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6b262a0 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 675f088b9ac4 to 68de6e352585 (1 revision) (#46956) 

    https://skia.googlesource.com/skia.git/+log/675f088b9ac4..68de6e352585

2023-10-16 [email protected] Move SkMultiPictureDocument functions into namespace in include/docs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c24f303 View commit details
    Browse the repository at this point in the history
Loading