Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bc4abcd
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 05fdf94
Choose a head ref
  • 9 commits
  • 39 files changed
  • 6 contributors

Commits on Mar 8, 2024

  1. Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (#51278) 

    https://skia.googlesource.com/skia.git/+log/bf3f9c5f0edb..093994f8f078

2024-03-08 [email protected] Roll SK Tool from 0dc646b71e8d to 886dbf1a5a87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4bb444f View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (#51280) 

    https://skia.googlesource.com/skia.git/+log/093994f8f078..15f8d03a9594

2024-03-08 [email protected] Roll Skia Infra from 0dc646b71e8d to 886dbf1a5a87 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    984c592 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (#51282) 

    https://skia.googlesource.com/skia.git/+log/15f8d03a9594..993a88a663c8

2024-03-08 [email protected] Roll Dawn from 58cd45951deb to 00ea56c88561 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6e45623 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (#51283) 

    https://skia.googlesource.com/skia.git/+log/993a88a663c8..a4fb847f47d9

2024-03-08 [email protected] Roll vulkan-deps from f2cacee81b83 to 3d5581c920a3 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4cf7319 View commit details
    Browse the repository at this point in the history

  5. Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn… 

    …-sdk (#51287)

The Dart -> Flutter Engine autoroller seems to be failing atm due to
fuchsia build errors.

The Dart SDK CL in [0] is depending on a fuchsia gn sdk import. The
import path defaults to `//third_party/fuchsia/gn-sdk` in the Dart build
rules.

Though flutter seemingly has it in `//flutter/tools/fuchsia/gn-sdk`
(which was added to DEPS in 8b24024)

=> This is an attempt to override the default & fix autoroller

[0] https://dart-review.googlesource.com/c/sdk/+/355283/14
    @mkustermann
    mkustermann authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6b5ab57 View commit details
    Browse the repository at this point in the history

  6. Update CI scripts to use either src/flutter/third_party/dart or src/t… 

    …hird_party/dart (#51276)

See flutter/flutter#143335
    @jason-simmons
    jason-simmons authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    04df0c7 View commit details
    Browse the repository at this point in the history

  7. Migrate vulkan_memory_allocator to flutter/third_party (#51275) 

    Migrates vulkan_memory_allocator from the buildroot's third_party directory to the engine's.

Issue: flutter/flutter#144812
Part of: flutter/flutter#67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    545fad8 View commit details
    Browse the repository at this point in the history

  8. [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (#51234) 

    This change updates test-scripts with https://crrev.com/c/5347216 so that it can override the sdk location from an env var. The override location can be used by update_product_bundles to download emulator images of an unreleased sdk from gcs buckets. The process is used by fuchsia lsc (https://ci.chromium.org/ui/p/turquoise/builders/global.ci/sdk-core-linux-flutter), now it's failing due to the wrong product_bundle location being used.

This change should have no impact to the existing builders since they do not use either gclient variables relevant. E.g. download_fuchsia_sdk and fuchsia_sdk_path.

Bug: http://b/328110079

FYI: @mbrase 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @zijiehe-google-com
    zijiehe-google-com authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6d7168c View commit details
    Browse the repository at this point in the history

  9. [Impeller] More efficient usage of transient onscreen attachments. (#… 

    …51206)

Work towards flutter/flutter#144617

> The primary trick here is making sure that the transient attachments for the onscreen (MSAA and Depth/Stencil) are effectively recycled. In fact, I think we can actually make a single Onscreen MSAA and Onscreen Depth/Stencil and share them across the swapchain images - as they should be effectively synchronized already.

Fixes flutter/flutter#141750
    Jonah Williams authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    05fdf94 View commit details
    Browse the repository at this point in the history
Loading