This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

11 commits
66 files changed
7 contributors

Commits on Oct 31, 2024

Embedder: migrate Metal surfaces to ARC (#56279 )

Migrate Skia and Impeller surface translation units to ARC.

Issue: flutter/flutter#137801

No changes to tests since no semantic changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

cbracken authored Oct 31, 2024

Vastly rewrite and expand et/README.md (#56250 )
```
Closes flutter/flutter#157876.

/cc @dcharkes @jensjoha as well (documented `--gn-args`)
```
matanlurey authored Oct 31, 2024
Configuration menu
View commit details

Copy full SHA for 76c6f79

Browse repository at this point
Copy the full SHA

76c6f79 View commit details

Browse the repository at this point in the history
[Impeller] make desktop GL render. (#56274 )
```
Fixes flutter/flutter#143387

Will be tested in flutter/flutter#157888
```
Jonah Williams authored Oct 31, 2024
Configuration menu
View commit details

Copy full SHA for ab00d95

Browse repository at this point
Copy the full SHA

ab00d95 View commit details

Browse the repository at this point in the history
[Impeller] Do not use fast mask blur for stroked shapes (#56247 )
```
A compound test for whether to use the fast blur mechanism for shapes was failing to check for a stroked shape due to misplaced parentheses.
```
flar authored Oct 31, 2024
Configuration menu
View commit details

Copy full SHA for 32b641e

Browse repository at this point
Copy the full SHA

32b641e View commit details

Browse the repository at this point in the history

Allow BufferViews to have non-owning references to DeviceBuffers (#56224

)

issue: flutter/flutter#157538

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

gaaclarke authored Oct 31, 2024

macOS: migrate third_party/accessibility to ARC (#56281 )

Migrates all Objective-C++ translation units under third_party/accessibility to ARC.

Issue: flutter/flutter#137801

No test changes because this change introduces no semantic changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

cbracken authored Oct 31, 2024

Reverts "Allow BufferViews to have non-owning references to DeviceBuf…

…fers (#56224)" (#56285)

Reverts: #56224
Initiated by: jonahwilliams
Reason for reverting: merge issue.
Original PR Author: gaaclarke

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
issue: flutter/flutter#157538

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

auto-submit[bot] authored Oct 31, 2024

reland: Allow BufferViews to have non-owning references to DeviceBuff…
```
…ers (#56286)

relands #56224

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
```
gaaclarke authored Oct 31, 2024
Configuration menu
View commit details

Copy full SHA for cd46383

Browse repository at this point
Copy the full SHA

cd46383 View commit details

Browse the repository at this point in the history