Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b11e318
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e2eee0
Choose a head ref
  • 4 commits
  • 29 files changed
  • 3 contributors

Commits on Nov 2, 2023

  1. [Impeller] Skia gold for flutter_tester dart tests. (#47066) 

    This removes skips for the golden tests in `//testing/dart/canvas_test.dart` and instead passes them up to Skia gold.

Adds a utility class for dealing with Skia gold from these tests, as well as the existing fuzzy identical image comparison for tests that just want to do in memory comparison of images generated from the same test.

Removes the old golden files that were in tree.

Part of flutter/flutter#53784
    @dnfield
    dnfield authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9d4c951 View commit details
    Browse the repository at this point in the history

  2. Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... ( 

    #47611)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    862172b View commit details
    Browse the repository at this point in the history

  3. Run tests on either macOS 12 or 13 (#47606) 

    In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ

Note: I'm leaving subtests of `Linux linux_web_engine` on Mac-12 since they're currently incompatible with MacOS 13.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ccee125 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (#47610) 

    https://skia.googlesource.com/skia.git/+log/2b3472da9888..306543797674

2023-11-02 [email protected] [infra] Add alias for Go
2023-11-02 [email protected] [graphite] Small misc. comment doc fixes
2023-11-02 [email protected] Revert "Decouple SVG from SkFontMgr::RefDefault()"
2023-11-02 [email protected] [graphite] Simplify PerEdgeAAQuadRenderStep frag shader and varyings.
2023-11-02 [email protected] Treat non-side-effecting prefix expressions as trivial.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1e2eee0 View commit details
    Browse the repository at this point in the history
Loading