Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ade8ef2
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ee5adf6
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Sep 11, 2024

  1. [Impeller] hash less text stuff per frame for text rendering. (#55060) 

    The Glyph color and stroke property are only required for stroked text or COLR text, in all other cases its a no-op. We can do the text hashing faster if we let these properties be optional.

~Also as an experiment switches to absl containers which should be more reasonably performant than std containers.~ required more changes, will try again later
    Jonah Williams authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    38e37ce View commit details
    Browse the repository at this point in the history

  2. Zip and upload Xcode xcresults on scenario test failure (#55093) 

    The `FLUTTER_ENGINE` has a `/` in it: `ci/ios_debug_unopt_sim`.  
```
path.join(storePath, '$iosEngineVariant.zip');
```
was resolving to `path_to_output/ci/ios_debug_unopt_sim.zip`.  `path_to_output` existed, but the `ci` directory didn't:

> zip error: Could not create output file (/Volumes/Work/s/w/ir/x/w/rc/flutter_logs_dir/ci/ios_debug_unopt_sim.zip)

Change the output zip path to `path_to_output/ci_ios_debug_unopt_sim.zip` with an underscore instead.

Fixes flutter/flutter#154956

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ee5adf6 View commit details
    Browse the repository at this point in the history
Loading