Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ad1343c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0d93da7
Choose a head ref
  • 9 commits
  • 7 files changed
  • 2 contributors

Commits on Jun 28, 2024

  1. Roll Dart SDK from 89b164e3adeb to 160ace00da8a (1 revision) (#53643) 

    https://dart.googlesource.com/sdk.git/+log/89b164e3adeb..160ace00da8a

2024-06-28 [email protected] Version 3.5.0-316.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e6fb48a View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 1ad84eb8e94f to bc0e9542ce83 (1 revision) (#53644) 

    https://skia.googlesource.com/skia.git/+log/1ad84eb8e94f..bc0e9542ce83

2024-06-28 [email protected] Roll vulkan-deps from 6583f5d23919 to 544502230988 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    40153cc View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Roll Dart SDK from 160ace00da8a to e1e2b16d509b (1 revision) (#53646) 

    https://dart.googlesource.com/sdk.git/+log/160ace00da8a..e1e2b16d509b

2024-06-29 [email protected] Version 3.5.0-317.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    eb0b7f2 View commit details
    Browse the repository at this point in the history

  2. [web] Fixes drag scrolling in embedded mode. (#53647) 

    When Flutter web runs embedded in a page, scrolling by dragging is interrupted very early by the browser.

It turns out that our `pointer` events receive a `pointercancel` + `pointerleave` by the browser because they happen in an area (the flutter glasspane) that is not really scrollable. [See documentation](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointercancel_event).

  > [!NOTE]
  > After the pointercancel event is fired, the browser will also send [pointerout](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointerout_event) followed by [pointerleave](https://developer.mozilla.org/en-US/docs/Web/API/Element/pointerleave_event).

(Firefox is a good browser to test this, because the browser will cancel our events **only if there's scrollable areas around the embedded flutter app**.)

There's several solutions, but one of them (used by PixiJS as well) is to cancel the `touchstart` event that fires with the `pointerdown` event.

(This PR also removes an unnecessary call to `addEventListener` in the `Listener` helper class, and adds some testing to it).

## Testing

* Added a happy case test for the fix (preventDefault on 'touchstart' events)
* Deployed demo app here: https://dit-multiview-scroll.web.app

## Issues

* Fixes flutter/flutter#138985
* Fixes flutter/flutter#146732
* Related to flutter/flutter#139263

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @ditman
    ditman authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f6004b9 View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Linux SDK from H_P7EHb4zXXV-Eiik... to zU9wwHk8Oji6pArmw… 

    …... (#53649)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    c9047ce View commit details
    Browse the repository at this point in the history

  4. Roll Skia from bc0e9542ce83 to 2df28ce437cc (1 revision) (#53652) 

    https://skia.googlesource.com/skia.git/+log/bc0e9542ce83..2df28ce437cc

2024-06-29 [email protected] Roll vulkan-deps from 544502230988 to 773555d3bd22 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2d130cf View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 2df28ce437cc to 34be7c830184 (1 revision) (#53654) 

    https://skia.googlesource.com/skia.git/+log/2df28ce437cc..34be7c830184

2024-06-29 [email protected] Manual roll Dawn from 9281ee0a120f to 66b3d4eee7e4 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    97b64a0 View commit details
    Browse the repository at this point in the history

  6. Roll Dart SDK from e1e2b16d509b to ab6a48438e07 (1 revision) (#53655) 

    https://dart.googlesource.com/sdk.git/+log/e1e2b16d509b..ab6a48438e07

2024-06-29 [email protected] Version 3.5.0-318.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    234e31c View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Roll Fuchsia Linux SDK from zU9wwHk8Oji6pArmw... to DSPuQ9O6WejkIBUUh… 

    …... (#53657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0d93da7 View commit details
    Browse the repository at this point in the history
Loading