Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab9daaa
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 94f56a2
Choose a head ref
  • 4 commits
  • 13 files changed
  • 3 contributors

Commits on Sep 13, 2024

  1. add back test itSendsTextShowPasswordToFrameworkOnAttach with new moc… 

    …k for display metrics (#55110)

Part 1/5 for re adding tests documented in flutter/flutter/issues/154746

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
    @reidbaker
    reidbaker authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1595e21 View commit details
    Browse the repository at this point in the history

  2. [skwasm] Scene builder optimizations for platform view placement (#54949 

    )

This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
    @eyebrowsoffire
    eyebrowsoffire authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    950f92f View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (#55182) 

    https://dart.googlesource.com/sdk.git/+log/eb664303c5ff..302b6472b849

2024-09-13 [email protected] Version 3.6.0-253.0.dev
2024-09-13 [email protected] Version 3.6.0-252.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    715ede5 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (#55187) 

    https://skia.googlesource.com/skia.git/+log/a5a6d12b3642..9877f459399a

2024-09-13 [email protected] Rename our_vulkan_headers use_skia_vulkan_headers
2024-09-13 [email protected] [bazel] Initial dm support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    94f56a2 View commit details
    Browse the repository at this point in the history
Loading