Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aa1278e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: da3721a
Choose a head ref
  • 5 commits
  • 45 files changed
  • 5 contributors

Commits on Jul 28, 2023

  1. [Android] Removes handling of Flutter splash screen (#44047) 

    Fixes flutter/flutter#105173.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @camsim99
    camsim99 authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    632b276 View commit details
    Browse the repository at this point in the history

  2. Roll ANGLE from c319f34c4c8c to 391bfa35798d (1 revision) (#44112) 

    https://chromium.googlesource.com/angle/angle.git/+log/c319f34c4c8c..391bfa35798d

2023-07-28 [email protected] Fix a missing symbol issue with CaptureReplayTests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    64e88e8 View commit details
    Browse the repository at this point in the history

  3. Remove a temporary lint ignore (#44091) 

    [The issue](https://github.com/dart-lang/linter/issues/4562) has been resolved.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @dkwingsmt
    dkwingsmt authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c00bcae View commit details
    Browse the repository at this point in the history

  4. Roll ANGLE from 391bfa35798d to 0abd6f549ff1 (2 revisions) (#44114) 

    https://chromium.googlesource.com/angle/angle.git/+log/391bfa35798d..0abd6f549ff1

2023-07-28 [email protected] Vulkan: Enable dynamic state on working Android drivers
2023-07-28 [email protected] VVL VUID-VkDescriptorImageInfo-imageView update

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c3d59de View commit details
    Browse the repository at this point in the history

  5. Listen to window notifications to update application lifecycle (#43558) 

    Use `WM_SIZE, WM_SHOWWINDOW, WM_SETFOCUS, and WM_KILLFOCUS` to update
the application lifecycle state on Windows.

flutter/flutter#103637

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Brandon DeRosier <[email protected]>
Co-authored-by: skia-flutter-autoroll <[email protected]>
    @yaakovschectman @bdero @skia-flutter-autoroll
    3 people authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    da3721a View commit details
    Browse the repository at this point in the history
Loading