Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a09295f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e99fc6e
Choose a head ref
  • 4 commits
  • 22 files changed
  • 2 contributors

Commits on Apr 25, 2024

  1. [Impeller] kick off registration and initial PSO compilation of runti… 

    …me effect earlier. (#52381)

I thought about changing this API so that it blocks on compilation, but I think that isn't necesasary as the workload can happen while the UI thread is building. Plus, even blocking on shader completion does not guarantee that we won't need to compile a variant anyway.

While I was at it I moved the descriptor sets computation to the runtime effect constructor.

With this change the pipleine variant used during the frame is produced much faster than the initial 12ms compilation.

![image](https://github.com/flutter/engine/assets/8975114/42626676-0a71-4503-a3e9-4109c36fbbef)

Fixes flutter/flutter#113719
Fixes flutter/flutter#141222
    Jonah Williams authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fd437e7 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from cb32ad619678 to 52083c205016 (1 revision) (#52396) 

    https://skia.googlesource.com/skia.git/+log/cb32ad619678..52083c205016

2024-04-25 [email protected] [graphite] Instantiate non-budgeted TextureProxies in Make()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e9afe03 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Vulkan validation off by default. (#52397) 

    Fixes flutter/flutter#142659

can be turned on via --enable-vulkan-validation cmd line flag.
    Jonah Williams authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0f31cba View commit details
    Browse the repository at this point in the history

  4. [Impeller] while we still have benchmarks, see if we're efficient eno… 

    …ugh for this to be faster. (#52398)

We don't need to decode images to a malloc'd buffer, but this benchmarked as faster because we did so much allocation during the frame. Maybe this is better now? Lets run the benchmarks
    Jonah Williams authored Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e99fc6e View commit details
    Browse the repository at this point in the history
Loading