Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9cb60de
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d47b038
Choose a head ref
  • 5 commits
  • 32 files changed
  • 3 contributors

Commits on May 8, 2024

  1. Roll Dart SDK from b7cad2edae4b to 673b3aa8558a (1 revision) (#52677) 

    https://dart.googlesource.com/sdk.git/+log/b7cad2edae4b..673b3aa8558a

2024-05-08 [email protected] Version 3.5.0-139.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    86d2768 View commit details
    Browse the repository at this point in the history

  2. [Impeller] require and use backpressure for AHB swapchain. (#52676) 

    I think we might be buffer stuffing on the A02s specifically. Though I don't know if this will just "fix" it by turning off the swapchain for that device.

flutter/flutter#147721
    Jonah Williams authored May 8, 2024
    Configuration menu
    Copy the full SHA
    0c41729 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from d8427844b843 to d965fc1fd319 (4 revisions) (#52679) 

    https://skia.googlesource.com/skia.git/+log/d8427844b843..d965fc1fd319

2024-05-08 [email protected] [graphite] Add child DrawTasks to DrawContexts when drawn; track pending reads
2024-05-08 [email protected] [graphite] Make MatrixConvolutionImageFilter stably keyed
2024-05-08 [email protected] [graphite] Don't instantiate budgeted Surfaces immediately
2024-05-08 [email protected] Update rules to enforce IWYU in the modular build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    cb7c1ed View commit details
    Browse the repository at this point in the history

  4. Revert 4846886 (#52680) 

    reverts #52526
fixes flutter/flutter#147989

That PR has broken playgrounds.  It's non essential so we can revert it an bdero can take a look whenever he gets another chance.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored May 8, 2024
    Configuration menu
    Copy the full SHA
    3513909 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from d965fc1fd319 to 4019d8957cff (2 revisions) (#52682) 

    https://skia.googlesource.com/skia.git/+log/d965fc1fd319..4019d8957cff

2024-05-08 [email protected] Reland "Update clang_win and win_toolchain assets"
2024-05-08 [email protected] Fix experimental use of generate_cpp_files_for_headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    d47b038 View commit details
    Browse the repository at this point in the history
Loading