Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 99fdac8
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 22bd35a
Choose a head ref
  • 3 commits
  • 11 files changed
  • 3 contributors

Commits on Aug 8, 2023

  1. [web] Expose the benchmark callback through dart:ui_web (#44461) 

    Required by flutter/flutter#132087
Part of flutter/flutter#130175
Part of flutter/flutter#126831
    @mdebbar
    mdebbar authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    73671d4 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from f7162d33afb2 to 66ba512c613c (8 revisions) (#44497) 

    https://skia.googlesource.com/skia.git/+log/f7162d33afb2..66ba512c613c

2023-08-08 [email protected] Move SkChromeRemoteGlyphCache.cpp to src/text/gpu
2023-08-08 [email protected] Revert "Use pointers to avoid static variable destruction."
2023-08-08 [email protected] Skip deleted test file
2023-08-08 [email protected] Add missing file to public.bzl
2023-08-08 [email protected] Disable MatrixScalarMath test on Mac ANGLE.
2023-08-08 [email protected] Roll vulkan-deps from c46d48f777b7 to cc5d2913cf83 (3 revisions)
2023-08-08 [email protected] Roll ANGLE from 135a24fc3706 to f7d7be8d2ff0 (13 revisions)
2023-08-08 [email protected] Roll Skia Infra from 0e52994bf1b6 to 333a87d1ef8a (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6987702 View commit details
    Browse the repository at this point in the history

  3. [macOS] Fix engine/binaryMessenger retain cycle (#44471) 

    Previously, FlutterEngine.binaryMessenger returned the FlutterEngine
instance itself, which meant that channels/plugins could hold a strong
reference to the engine and thus cause a retain cycle, preventing the
engine from being deallocated.

We introduce FlutterBinaryMessengerRelay, which implements the
FlutterBinaryMessenger protocol, by delegating back to the engine, to
which it holds a weak reference, thus avoiding the retain cycle.

This also changes the FlutterBinaryMessengerRelay.parent property from
an assign property to a weak property since that code is compiled with
ARC enabled as of #44395.

This patch also rearranges the headers to comply with our style guide:
related headers for this file, C headers, C++ headers, other Flutter
headers, in that order.

Fixes: flutter/flutter#116445
    @cbracken
    cbracken authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    22bd35a View commit details
    Browse the repository at this point in the history
Loading