Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 96061d6
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 142882e
Choose a head ref
  • 9 commits
  • 12 files changed
  • 4 contributors

Commits on Feb 28, 2020

  1. Add support for software text editing controls (#15560)

    * Add support for software text editing controls
    
    Includes selection, copy, cut, paste, as well as partial support for up
    and down movement.
    
    Text editing controls can be accessed in GBoard by:
      top-left arrow > three dots menu > text editing
    
    Partial fix for flutter/flutter#9419 and flutter/flutter#37371.
    
    * Introduce InputConnectionAdaptor tests
    
    Run with:
      testing/run_tests.py --type=java --java-filter=io.flutter.plugin.editing.InputConnectionAdaptorTest
    
    * Fix BUILD.gn comment on run_tests.py --java-filter flag
    edman authored Feb 28, 2020
    Configuration menu
    Copy the full SHA
    9beac71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab9f83f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    62d0c08 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76d12d2 View commit details
    Browse the repository at this point in the history
  5. Try rasterizing images and layers only once, even when their rasteriz…

    …ation fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)
    
    If Rasterization fails, i.e. image.is_valid() is false, the cache might try rasterizing the image again on the next frame. Not only is this wasteful put might also prevent other pictures to be cached within the current frame budget.
    ignatz authored Feb 28, 2020
    Configuration menu
    Copy the full SHA
    01a52b9 View commit details
    Browse the repository at this point in the history
  6. script for fetching correct flutter version (#16818)

    * script for fetching correct flutter version
    
    * change cirrus yml for the script location
    
    * change location of the script. Add it to tools
    
    * cirrus still does not see the script. repeat path change from the previous step
    
    * Looks like script worked correctly. do not change directory.
    
    * change directory back to build root after scriot is run
    
    * script runs ok. Still not able to find the bin directory. go all the way back
    
    * still can't see the bin directory. carry the script content to cirrus.yml to debug better
    
    * get the last commit id of the right repository
    
    * content of the script worked in cirrus. call the script from tools
    
    * cannot find the script under tools
    
    * print the current path in the script to see why cirrus cannot see bin directory
    
    * move to flutter path before running update packages
    
    * tests run now. remove print outs
    
    * error if the ENGINE_PATH is not set. exit the script
    
    * addressing reviewer comments
    
    * engine branch name on cirrus logs doesn't make sense
    
    * fix typo
    
    * change the directory of branch calculation
    
    * remove extra logs
    
    * addressing PR comments. Testing CIRRUS_CI env variable
    
    * adding CIRRUS_CI check
    Nurhan Turgut authored Feb 28, 2020
    Configuration menu
    Copy the full SHA
    3b0d1a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Configuration menu
    Copy the full SHA
    9746ddb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90736bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    142882e View commit details
    Browse the repository at this point in the history
Loading