Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 90c4d64
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 016206d
Choose a head ref
  • 2 commits
  • 9 files changed
  • 2 contributors

Commits on Mar 18, 2024

  1. [web] remove Tappable from basic set of a11y roles; add it case by ca… 

    …se (#51466)

Remove the `Tappable` role from the `PrimaryRoleManager.withBasics` constructor. Only add `Tappable` to primary roles that know for sure they need it.

Fixes flutter/flutter#144364
    @yjbanov
    yjbanov authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ad75e93 View commit details
    Browse the repository at this point in the history

  2. Support accessibility back gesture to pop route from view controller (#… 

    …51241)

Adapted suggestion from flutter/flutter#74246 (comment) to pop the route if the view controller route if `accessibilityPerformEscape` is called at that level in the responder chain.

Ideally this could know if the route was successfully popped, and only then return `YES` (halting propagation through the responder chain).

I confirmed by editing https://docs.flutter.dev/cookbook/navigation/navigation-basics#interactive-example as a demo that that the two-finger scrub (move two fingers back and forth three times quickly, making a "z") navigates back to the last route, and that the [`SementicObject`](https://github.com/flutter/engine/blob/88882292c952d76069cee67d76acc0fbae51c749/shell/platform/darwin/ios/framework/Source/SemanticsObject.mm#L763) scrub, which already worked, continued to work.

I'm not super familiar with this code, hopefully there aren't further gotchas I'm not thinking of.

Fixes flutter/flutter#74246

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    016206d View commit details
    Browse the repository at this point in the history
Loading