Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9039c2d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bca11a4
Choose a head ref
  • 2 commits
  • 14 files changed
  • 2 contributors

Commits on May 18, 2023

  1. Configuration menu
    Copy the full SHA
    be57de6 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. [web:a11y] support dialogs described by descendants (#42108)

    Add a new `RouteName` semantic role for nodes with `namesRoute` set without a `scopesRoute`. Such nodes provide a description for the nearest ancestor dialog node. The web equivalent of this is when an element `role="dialog"` is described by pointing to one of its children using `aria-labelledby` and `aria-describedby`. Here's an example:
    
    ```
    <div
      role="dialog"
      aria-labelledby="dialog1Title"
      aria-describedby="dialog1Desc">
      <h2 id="dialog1Title">Your personal details were successfully updated</h2>
      <p id="dialog1Desc">
        You can change your details at any time in the user account section.
      </p>
      <button>Close</button>
    </div>
    ```
    
    ([Source](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role))
    
    Flutter currently does not distinguish between "labelled by" and "described by". In my testing, only `aria-describedby` resulted in an announcement of the dialog's description upon opening. `aria-labelledby` required that the dialog element itself be focusable, which is not the case. So I went with `aria-describedby`.
    
    Fixes flutter/flutter#126030
    yjbanov authored May 19, 2023
    Configuration menu
    Copy the full SHA
    bca11a4 View commit details
    Browse the repository at this point in the history
Loading