Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7f15dc1
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d46c1fa
Choose a head ref
  • 2 commits
  • 38 files changed
  • 2 contributors

Commits on Mar 16, 2024

  1. Re-land "[Impeller] A toolkit for managed handles to Android NDK vend… 

    …ed objects." (#51460)

This reverts commit 80a93a0.

The original cause of the revert was a flake introduced because the unit-test could request a frame from the Choreographer if it ran long enough. The availability checks in the choreographer were inaccurate after we intentionally backed out of using the Callback32 variant on 32 bit platforms.

The new tests didn't catch it because of an unrelated issue. In the first version of the patch for review, the proc table was only supposed to run on API levels 29 and above. When @dnfield requested we also get rid of the NDK helpers, the choreographer and additional utilities were added. But the API level gate in the new test harness wasn't removed. This made the tests be skipped. That gate has been removed entirely now. The error that cause the revert because of flakiness will now be a reliable failure.
    @chinmaygarde
    chinmaygarde authored Mar 16, 2024
    Configuration menu
    Copy the full SHA
    eb0d024 View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from 03cc4d817056 to 2241333f69f3 (2 revisions) (#51461) 

    https://dart.googlesource.com/sdk.git/+log/03cc4d817056..2241333f69f3

2024-03-15 [email protected] Version 3.4.0-238.0.dev
2024-03-15 [email protected] Version 3.4.0-237.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 16, 2024
    Configuration menu
    Copy the full SHA
    d46c1fa View commit details
    Browse the repository at this point in the history
Loading