Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 751ab9b
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 33ac1b3
Choose a head ref
  • 4 commits
  • 20 files changed
  • 3 contributors

Commits on Oct 2, 2024

  1. Reland "[canvaskit] Further improve overlay optimization by splitting… 

    … pictures" (#55563)

This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis.

Fixes flutter/flutter#149863
Fixes flutter/flutter#155833

On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps).

This is a reland of #54878 with a fix for scenes with pictures and shader masks that are eventually entirely clipped out. It also fixes a performance issue caused by making too many Canvases just to record the size of the picture elements in the scene.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @harryterkelsen
    harryterkelsen authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    804f434 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 61bb59fcef34 to 40d51ebc76db (1 revision) (#55593) 

    https://skia.googlesource.com/skia.git/+log/61bb59fcef34..40d51ebc76db

2024-10-02 [email protected] Fix BigImageTest caps check

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    11f0a08 View commit details
    Browse the repository at this point in the history

  3. Remove all use of gn desc global test fixtures. (#55592) 

    Closes flutter/flutter#148420.
    @matanlurey
    matanlurey authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5aeb2bd View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from 7d0becb773d1 to 14b931c40076 (2 revisions) (#55594) 

    https://dart.googlesource.com/sdk.git/+log/7d0becb773d1..14b931c40076

2024-10-02 [email protected] Version 3.6.0-313.0.dev
2024-10-02 [email protected] Version 3.6.0-312.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    33ac1b3 View commit details
    Browse the repository at this point in the history
Loading